Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update markdown-highlighter.rb #120

Closed
wants to merge 2 commits into from
Closed

Update markdown-highlighter.rb #120

wants to merge 2 commits into from

Conversation

hqweay
Copy link
Contributor

@hqweay hqweay commented Jun 23, 2022

highlight supports Asian Language

@maximevaillancourt
Copy link
Owner

maximevaillancourt commented Jun 26, 2022

Thank you for your contribution, hqweay!

Could you add an example in your-first-note.md (somewhere around here) to demonstrate the changes introduced in this pull request? Once that's done, we should be good to merge this. Thanks! 🙏

@hqweay
Copy link
Contributor Author

hqweay commented Jun 27, 2022

Thank you for your contribution, hqweay!

Could you add an example in your-first-note.md (somewhere around here) to demonstrate the changes introduced in this pull request? Once that's done, we should be good to merge this. Thanks! 🙏

OK. By the way, I just found it can't match sentences like :

  • ==「但是」==
  • =="good"==
    how do you think ==+([^ ](.*?)?[^ .=]?)==+?

image

image

@maximevaillancourt
Copy link
Owner

how do you think ==+([^ ](.*?)?[^ .=]?)==+?

That seems reasonable, let's try it out 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants