Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update bidirectional_links_generator.rb #64

Merged
merged 2 commits into from
Jun 17, 2021
Merged

Update bidirectional_links_generator.rb #64

merged 2 commits into from
Jun 17, 2021

Conversation

manunamz
Copy link
Contributor

Make 'invalid_wiki_link' regex less greedy.

@manunamz
Update bidirectional_links_generator.rb
bf7e92f 
Make 'invalid_wiki_link' regex less greedy.
@manunamz
Copy link
Contributor Author

manunamz commented Jun 12, 2021 •
edited
Loading

Fix over-greediness of regex captures, see behavior difference below:

\[\[(.*)\]\]
Screen Shot 2021-06-11 at 8 56 09 PM
\[\[([^\]]+)\]\]
Screen Shot 2021-06-11 at 8 56 20 PM

@maximevaillancourt
Copy link
Owner

maximevaillancourt commented Jun 13, 2021 •
edited
Loading

Thanks for the improvement! Just needs a quick rebase on master (now that #63 is merged), then this will be good to go.

@maximevaillancourt maximevaillancourt merged commit ad94b73 into maximevaillancourt:master Jun 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@manunamz @maximevaillancourt