feat(crd): use unstructured type inplace of typed crd instance #187
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AmitKumarDas
requested review from
mittachaitu,
rohan2794,
amitbhatt818 and
vishnuitta
This commit makes exhaustive changes to handle CRD instances. CRD instances make use of unstructured types instead of typed instances. Both CRD versions i.e. v1beta1 & v1 are supported. Unstructured instances have proved to be generic & testable versus the typed counterparts especially for CRD schemas that can differ from each other. In other words, CRD schemas have a majority schemaless section that is well handled via unstructured type. This commit also includes a number of integration test cases to avoid bug injections if any. This closes mayadata-io#186 partially. A better approach will be to use latest version of d-operators with clients that make use of unstructured instances directly instead of yaml strings that get converted to go structures. This commit is also a breaking change, since some of the structures have been modified. Clients that are already making use of this structure need to be modified accordingly. Signed-off-by: AmitKumarDas <amit.das@mayadata.io>
mittachaitu
approved these changes
Jan 4, 2021
|
🎉 This PR is included in version 1.29.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit makes exhaustive changes to handle CRD instances. CRD instances make use of unstructured types instead of typed instances. Both CRD versions i.e. v1beta1 & v1 are supported.
Unstructured instances have proved to be generic & testable versus the typed counterparts especially for CRD schemas that can differ from each other. In other words, CRD schemas have a
majority schemaless section that is well handled via unstructured type.
This commit also includes a number of integration test cases to avoid bug injections if any.
This closes #186 partially. A better approach will be to use latest version of d-operators with clients that make use of unstructured instances
directly instead of yaml strings that get converted to go structures.
This commit is also a breaking change, since some of the structures have been modified. Clients that are already making use of this structure need to be modified accordingly.
Signed-off-by: AmitKumarDas amit.das@mayadata.io