Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(crd): use unstructured type inplace of typed crd instance #187

Merged
merged 1 commit into from
Jan 4, 2021
Merged

feat(crd): use unstructured type inplace of typed crd instance #187

merged 1 commit into from
Jan 4, 2021

Commits on Jan 4, 2021

  1. feat(crd): use unstructured type inplace of typed crd instance 

    This commit makes exhaustive changes to handle CRD instances.
CRD instances make use of unstructured types instead of typed
instances. Both CRD versions i.e. v1beta1 & v1 are supported.

Unstructured instances have proved to be generic & testable
versus the typed counterparts especially for CRD schemas that
can differ from each other. In other words, CRD schemas have a
majority schemaless section that is well handled via
unstructured type.

This commit also includes a number of integration test cases
to avoid bug injections if any.

This closes mayadata-io#186
partially. A better approach will be to use latest version of
d-operators with clients that make use of unstructured instances
directly instead of yaml strings that get converted to go
structures.

This commit is also a breaking change, since some of the
structures have been modified. Clients that are already making use
of this structure need to be modified accordingly.

Signed-off-by: AmitKumarDas <amit.das@mayadata.io>
    AmitKumarDas committed Jan 4, 2021
    Configuration menu
    Copy the full SHA
    0b041f0 View commit details
    Browse the repository at this point in the history