feat(recipe): delete all resources belonging to a gvk from a particular namespace #101

amitbhatt818 · 2020-07-22T18:37:38Z

Why We Need This PR?

We have feature to delete a particular Kubernetes Native resources.
But sometimes there are requirements to delete all the resources present in that particular namespace.
So this PR helps user to delete all the resources present in that particular namespaces.
This PR helps up to achieve this.

Some more Information:

Experiment YAML

apiVersion: dope.metacontroller.io/v1
kind: Recipe
metadata:
  name: delete-all-3
  namespace: d-testing
  labels:
    d-testing.dope.metacontroller.io/enabled: "true"
spec:
  tasks:
  - name: delete-all
    deleteAll:
      state:
        kind: Pod
        apiVersion: v1
        metadata:
          namespace: test
---

Result

Name:         delete-all-3
Namespace:    d-testing
Labels:       d-testing.dope.metacontroller.io/enabled=true
              recipe.dope.metacontroller.io/phase=Completed
Annotations:  <none>
API Version:  dope.metacontroller.io/v1
Kind:         Recipe
Metadata:
  Creation Timestamp:  2020-07-24T14:17:49Z
  Generation:          1
  Resource Version:    33969192
  Self Link:           /apis/metacontroller.app/v1/namespaces/d-testing/jobs/delete-all-3
  UID:                 12902e00-7132-4064-8cc4-70bb3646d591
Spec:
  Tasks:
    Delete All:
      State:
        API Version:  v1
        Kind:         Pod
        Metadata:
          Namespace:  test
    Name:             delete-all
Status:
  Failed Task Count:  0
  Message:            
  Phase:              Completed
  Reason:             
  Task Count:         1
  Task List Status:
    Delete - All:
      Message:  DeleteAll: Resource test v1: GVK Pod
      Phase:    Passed
      Step:     1
    delete-all-3-lock:
      Internal:  true
      Message:   Create: Lock d-testing delete-all-3-lock: GVK /v1, Kind=ConfigMap
      Phase:     Passed
      Step:      0
    delete-all-3-unlock:
      Internal:  true
      Message:   Locked forever
      Phase:     Passed
      Step:      3
    Job - Elapsed - Time:
      Elapsed Time In Seconds:  0.03936893
      Internal:                 true
      Phase:                    Passed
      Step:                     2
Events:                         <none>

Signed-off-by: Amit Bhatt amitbhatt818@gmail.com

AmitKumarDas · 2020-07-23T04:28:02Z

pkg/job/delete_all.go

@@ -0,0 +1,49 @@
+package job


@amitbhatt818 One of the first things that I would do is to explain what this PR is all about in the PR body.
It should explain everything to a reviewer to let this reviewer help as much as possible.
Note that a reviewer may be a maintainer or a new contributor to this project. The levels of knowledge & expertise will vary. We should put all effort to explain things in a manner it can be understood by all these personas.

Can you rebase from master?

Added description in the PR body. And rebased the branch.

AmitKumarDas · 2020-07-23T04:28:50Z

pkg/job/delete_all.go

+
+func (r *TaskRunner) deleteAll() (*types.TaskStatus, error) {
+	var message = fmt.Sprintf(
+		"Delete: Resource %s %s: GVK %s",


The message should start as DeleteAll: ...

AmitKumarDas · 2020-07-23T04:30:51Z

pkg/job/delete_all.go

+	"openebs.io/metac/dynamic/clientset"
+)
+
+func (r *TaskRunner) deleteAll() (*types.TaskStatus, error) {


Do you think this should have a dedicated struct. For example:

type Deleting struct {} func NewDeleter(config DeletingConfig) *Deleting {} func (d *Deleting) DeleteAll() {} func (d *Deleting) Delete() {}

AmitKumarDas · 2020-07-23T06:18:39Z

pkg/job/delete_all.go

+	err = client.
+		Namespace(r.Task.DeleteAll.State.GetNamespace()).
+		Delete(
+			r.Task.DeleteAll.State.GetKind(),


Delete does not take kind as an argument. It takes Name.
In this case we should use DeleteAll or DeleteCollection method.

Thanks 👍

AmitKumarDas · 2020-07-23T06:22:20Z

pkg/job/task.go

@@ -256,6 +265,7 @@ func (r *TaskRunner) Run() (types.TaskStatus, error) {
 		r.tryRunAssert,
 		r.tryRunDelete,
 		r.tryRunApply,
+		r.tryRunDeleteAll,


can you rearrange tryRunDeleteAll just after tryRunDelete

Resolved this comment

AmitKumarDas · 2020-07-23T06:23:02Z

types/job/delete_all.go

+	"k8s.io/apimachinery/pkg/apis/meta/v1/unstructured"
+)
+
+// DeleteAll deletes the state found in the cluster


can you explain this better

Changed the comment

AmitKumarDas · 2020-07-23T06:24:22Z

pkg/job/delete_all.go

+	"openebs.io/metac/dynamic/clientset"
+)
+
+func (r *TaskRunner) deleteAll() (*types.TaskStatus, error) {


Please add Unit Tests for all the changes or additions.

I will add unit test for these all changes In my coming PR @AmitKumarDas

Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>

amitbhatt818 requested a review from AmitKumarDas July 22, 2020 18:37

amitbhatt818 self-assigned this Jul 22, 2020

AmitKumarDas reviewed Jul 23, 2020

View reviewed changes

AmitKumarDas changed the title ~~(feat):Delete all resources present in particular namespace~~ feat: delete all resources belonging to a gvk from a particular namespace Jul 23, 2020

AmitKumarDas reviewed Jul 23, 2020

View reviewed changes

amitbhatt818 added 4 commits July 25, 2020 00:31

Delete all resources present in particular namespace

37fc661

Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>

Changed methord name

64cbb60

Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>

Changed job to recipe

c393864

Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>

Added comments

c13b5ac

Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>

amitbhatt818 added the feature flag label Jul 25, 2020

amitbhatt818 requested a review from harshshekhar15 July 25, 2020 14:05

amitbhatt818 marked this pull request as ready for review July 25, 2020 14:05

AmitKumarDas changed the title ~~feat: delete all resources belonging to a gvk from a particular namespace~~ feat(recipe): delete all resources belonging to a gvk from a particular namespace Aug 5, 2020

AmitKumarDas added delete recipe use case labels Aug 5, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(recipe): delete all resources belonging to a gvk from a particular namespace #101

feat(recipe): delete all resources belonging to a gvk from a particular namespace #101

amitbhatt818 commented Jul 22, 2020 •

edited

Loading

AmitKumarDas Jul 23, 2020 •

edited

Loading

amitbhatt818 Jul 25, 2020

AmitKumarDas Jul 23, 2020

amitbhatt818 Jul 25, 2020

AmitKumarDas Jul 23, 2020

AmitKumarDas Jul 23, 2020

amitbhatt818 Jul 25, 2020

AmitKumarDas Jul 23, 2020

amitbhatt818 Jul 25, 2020

AmitKumarDas Jul 23, 2020

amitbhatt818 Jul 25, 2020

AmitKumarDas Jul 23, 2020

amitbhatt818 Jul 25, 2020

feat(recipe): delete all resources belonging to a gvk from a particular namespace #101

Are you sure you want to change the base?

feat(recipe): delete all resources belonging to a gvk from a particular namespace #101

Conversation

amitbhatt818 commented Jul 22, 2020 • edited Loading

Why We Need This PR?

Some more Information:

Experiment YAML

Result

AmitKumarDas Jul 23, 2020 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

amitbhatt818 commented Jul 22, 2020 •

edited

Loading

AmitKumarDas Jul 23, 2020 •

edited

Loading