Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(deploy): Added statefulset yaml to deploy dope #69

Merged
merged 1 commit into from
Jun 4, 2020
Merged

chore(deploy): Added statefulset yaml to deploy dope #69

merged 1 commit into from
Jun 4, 2020

Conversation

amitbhatt818
Copy link
Contributor

@amitbhatt818 amitbhatt818 commented Jun 4, 2020 •
edited
Loading

Signed-off-by: Amit Bhatt amitbhatt818@gmail.com

  • This PR adds statefulset yml which will help in deploying dope.

@AmitKumarDas AmitKumarDas self-requested a review June 4, 2020 13:39
@AmitKumarDas AmitKumarDas added deploy documentation Improvements or additions to documentation labels Jun 4, 2020
@AmitKumarDas
Copy link

thanks @amitbhatt818
Can we keep the crd, rbac in manifests folder?
https://github.com/mayadata-io/d-operators/blob/master/test/setup/controlplane/setup.yaml depends on them.

AmitKumarDas
AmitKumarDas reviewed Jun 4, 2020
View reviewed changes
Copy link

@AmitKumarDas AmitKumarDas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @amitbhatt818 Have given a comment

@amitbhatt818
Added statefulset yaml to deploy dope
86b6a46 
Signed-off-by: Amit Bhatt <amitbhatt818@gmail.com>
@amitbhatt818
Copy link
Contributor Author

thanks @amitbhatt818
Can we keep the crd, rbac in manifests folder?
https://github.com/mayadata-io/d-operators/blob/master/test/setup/controlplane/setup.yaml depends on them.
Ok @AmitKumarDas

@amitbhatt818
Copy link
Contributor Author

Thanks @amitbhatt818 Have given a comment

Resolved comments PTAL @AmitKumarDas

@AmitKumarDas AmitKumarDas merged commit 59e2d10 into mayadata-io:master Jun 4, 2020
@AmitKumarDas AmitKumarDas changed the title [fix]:Added statefulset yaml to deploy dope chore(deploy): Added statefulset yaml to deploy dope Jun 4, 2020
@amitbhatt818 amitbhatt818 deleted the yml branch June 4, 2020 17:23
@AmitKumarDas
Copy link

🎉 This PR is included in version 1.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AmitKumarDas AmitKumarDas AmitKumarDas approved these changes

Assignees

@amitbhatt818 amitbhatt818

Labels
deploy documentation Improvements or additions to documentation released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@amitbhatt818 @AmitKumarDas