Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken Demo #3

Closed
tdaubs opened this issue Aug 22, 2016 · 3 comments
Closed

Broken Demo #3

tdaubs opened this issue Aug 22, 2016 · 3 comments
Labels
Milestone

Comments

@tdaubs
Copy link

tdaubs commented Aug 22, 2016

Demo doesn't seem to be working.

@maydemirx
Copy link
Owner

Can you check again?

@tdaubs
Copy link
Author

tdaubs commented Aug 23, 2016

After a bit of testing, it seems it's more of a UI issue. Yes, the filter does work but only after you click back on the map. In my opinion, it should trigger at the moment a checkbox is selected or deselected.

I might add, too, that the demo has a checkbox for none which is redundant. If no checkboxes are selected, the user should assume that nothing will display.

@maydemirx
Copy link
Owner

"The filter should be work at the check/uncheck time" maybe this request can be new feature. This not a bug. Because filter triggered at the popup closed.

If there is no selected any checkbox then the plugin does not need filter anything.

@maydemirx maydemirx added this to the v0.0.4 milestone Aug 24, 2016
maydemirx pushed a commit that referenced this issue Feb 9, 2017
improved ui. styles changed and #3 fixed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants