Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong register number for RegPaDac in radio.c #47

Closed
cyberman54 opened this issue Jan 28, 2018 · 1 comment
Closed

Wrong register number for RegPaDac in radio.c #47

cyberman54 opened this issue Jan 28, 2018 · 1 comment
Assignees
@terrillmoore
Labels
bug

Comments

@cyberman54
Copy link

wrong RegPaDAC register number in radio.c
RegPaDac has register number 0x4D, not 0x5A, referencing to Semtech SX1276 datasheet.
@terrillmoore terrillmoore self-assigned this Feb 7, 2018
@terrillmoore
Copy link
Member

Agreed, this is wrong. Apparently innocuous because the default setting is the same as the value that's always written. I'll do a pull request. Thanks!

terrillmoore added a commit that referenced this issue Feb 7, 2018
@terrillmoore
Fix #47: wrong value for RegPaDAC
df92beb
@terrillmoore terrillmoore mentioned this issue Feb 7, 2018
Merged
terrillmoore added a commit that referenced this issue Feb 7, 2018
@terrillmoore
Merge pull request #49 from mcci-catena/issue47
896fb80 
Fix #47: wrong value for RegPaDAC
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@terrillmoore terrillmoore

Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cyberman54 @terrillmoore