Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker ttn dashboard v1.0 #56

Merged

Conversation

MuruganChandrasekar
Copy link
Contributor

Please check it and let me know if changes required.

--Murugan Chandrasekar

@MuruganChandrasekar
Copy link
Contributor Author

Why is line 70 needed ?

As you can see in the Dockerfile that we are using FROM phusion/baseimage, we have to keep scripts that we want to run during startup.

Please refer link: https://github.com/phusion/baseimage-docker

In the README.md file, it is saying like below.

Running scripts during container startup
The baseimage-docker init system, /sbin/my_init, runs the following scripts during startup, in the following order:

All executable scripts in /etc/my_init.d, if this directory exists. The scripts are run in lexicographic order.
The script /etc/rc.local, if this file exists.
All scripts must exit correctly, e.g. with exit code 0. If any script exits with a non-zero exit code, the booting will fail.

@MuruganChandrasekar
Copy link
Contributor Author

I was wondering why the mkdir -p /etc/my_init.d because of line 66 (COPY), so /etc/my_init.d already exists then, or did I miss something ?

Yes you are right!. No need to create /etc/my_init.d directory in the phusion/baseimage since the directory is existing by default.

Thanks for your inputs on this.

@terrillmoore
Copy link
Member

@MuruganChandrasekar where are we on this? there are conflicts that need to be resolved before we can merge. Is this PR still live?

@MuruganChandrasekar
Copy link
Contributor Author

MuruganChandrasekar commented Mar 12, 2020

@MuruganChandrasekar where are we on this? there are conflicts that need to be resolved before we can merge. Is this PR still live?

Yes, this PR is still live. I want you to have a look at the changes and test it on your end before doing merge.

@MuruganChandrasekar
Copy link
Contributor Author

Yes. but our motive is to run the selected task given to crontab while building.

@terrillmoore terrillmoore changed the base branch from master to dev-v1 May 20, 2020 14:01
@terrillmoore terrillmoore merged commit b842d86 into mcci-catena:dev-v1 May 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants