Trying to get it to work on 0.14, but it doesn't work yet #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The unstable branch worked with previous betas of 0.14, but if the 0.14 API changed, then it could stop working... I had missed 0.14 was released, I will look at it. lovr-oculus-mobile does not work with 0.14 (there is a version that works with a 0.14 beta). One of the main advantages of 0.14 is you are supposed to not need lovr-oculus-mobile anymore. |
|
Unstable.
Thanks for the clarification!
The changelog for 0.14 can be found here:
https://github.com/bjornbytes/lovr/releases/tag/v0.14.0
…On Mon, Oct 19, 2020, 17:00 mcclure ***@***.***> wrote:
The unstable branch worked with previous betas of 0.14, but if the 0.14
API changed, then it could stop working...
I had missed 0.14 was released, I will look at it.
lovr-oculus-mobile does not work with 0.14. One of the main advantages of
0.14 is you are supposed to not need lovr-oculus-mobile anymore.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#2 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAAFNAES7NGBDXR6RO2P5ITSLRIB5ANCNFSM4SV4RB3A>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's crashing because
arg[0]is empty right now, which I'm confused about.Although it should be said I did not use https://github.com/mcclure/lovr-oculus-mobile. Does that repo work with 0.14? I did not try, I just assumed it didn't but maybe that's my fault. Instead I followed the compilation instructions in the LÖVR docs for Android/CMake and added the LODR files.