-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Docs] Fix examples section of several API references #661
Conversation
for more information, see https://pre-commit.ci
@maxschulz-COL your changes are overwritten by |
What a bummer... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All good from my side 👍 Seems like the docs don't like the typing for the kwargs argument though 😅 Hope we can fix it easily 🤞
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After applying Li's suggestions, this is going to be ready for merge by my opinion 👍
Just for reference, the initial behaviour was actually a bug: astral-sh/ruff#13139 This PR fixes those issues though, but will be goof to remember for posterity |
Description
Missing
:
does not render docs examples properlyScreenshot
Notice
I acknowledge and agree that, by checking this box and clicking "Submit Pull Request":