Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release tar does not compile #71

Closed
winni2k opened this issue Aug 6, 2018 · 2 comments
Closed

Release tar does not compile #71

winni2k opened this issue Aug 6, 2018 · 2 comments

Comments

@winni2k
Copy link

winni2k commented Aug 6, 2018

It appears that the most recent v0.2 release tar-ball does not contain the code in submodules. That makes it practically impossible to compile just from the tar-ball. Being able to compile from the tar-ball would make packaging in conda easier, as I don't think the --recursive keyword has been implemented in conda yet.

@noporpoise
Copy link
Member

I've created a new release and attached tar-ball and zip of the repo with dependencies: https://github.com/mcveanlab/mccortex/releases/tag/mccortex-1.0

Does that work?

@winni2k
Copy link
Author

winni2k commented Aug 20, 2018

It looks like it does!
I can confirm that I can compile and run tests on a Red Hat 4.8.5-28 and a Mac OS 10.13.6 machine.

@winni2k winni2k closed this as completed Aug 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants