make getMultiple
include pornographic mangas
#61
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
oh my GOD IT HAPPENED AGAIN NOO-
i am going insane
Manga.getMultiple()
does not work with pornographic rated manga; however, it works forerotica
,suggestive
, andsafe
.Results
this is speculative, but it appears that the reason this happens is because the
util
function fills in its ownsearchParameters
, which does not take in considerationcontentRating
, thus leading mangadex to fill incontentRating
to['safe', 'suggestive', 'erotica']
by default.i determined that the fix with the least amount of casualties would just be to add a
parameterObject
parameter togetMultipleIds(...)
. i thought this would be best instead of creating a new function since the latter would make cluttersince only one function would use it - that being the manga function. with this fix, only one other function would be changed,
and that would be in
cover.js
where i had to fill in an empty object to compensate for the new parameter.also made a new test for the heehoos
this was my first PR ever so apologies if i did something wrong !!