Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

missing _badge.scss and others #1216

Closed
tkuther opened this issue Sep 5, 2017 · 3 comments
Closed

missing _badge.scss and others #1216

tkuther opened this issue Sep 5, 2017 · 3 comments

Comments

@tkuther
Copy link
Contributor

tkuther commented Sep 5, 2017

I'm looking at https://fezvrasta.github.io/bootstrap-material-design/docs/4.0/components/badge/

Though, the _badge.scss is missing in https://github.com/FezVrasta/bootstrap-material-design/tree/master/scss

Also missing: _images.scss, _jumbotron.scss, _media.scss, _carousel.scss
_cards.scss is _card.scss in mainline bootstrap 4-beta

Is this supposed to be that way and one should load the mainline bootstrap css before the material one?

@FezVrasta
Copy link
Contributor

Material Design for Bootstrap 4 is based upon the Bootstrap 4 source, it simply imports it and extends/overrides the needed parts.

If a file doesn't need any modification, we don't define any override in our own source code.

@tkuther
Copy link
Contributor Author

tkuther commented Sep 5, 2017

OK, thanks for your explanation.

But even on your own page https://fezvrasta.github.io/bootstrap-material-design/docs/4.0/components/badge/ - the CSS for the badges is missing.

@FezVrasta
Copy link
Contributor

Good catch, then we definitely have to support them.

@FezVrasta FezVrasta reopened this Sep 5, 2017
@FezVrasta FezVrasta changed the title V4: missing _badge.scss and others missing _badge.scss and others Sep 5, 2017
tkuther added a commit to tkuther/bootstrap-material-design that referenced this issue Sep 5, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants