Properly detect min and max element in array (trekhleb#224)

mdeora · Oct 17, 2018 · 6bd6072 · 6bd6072
1 parent 5d12638
commit 6bd6072
Showing 1 changed file with 2 additions and 6 deletions.
diff --git a/src/algorithms/sorting/counting-sort/__test__/CountingSort.test.js b/src/algorithms/sorting/counting-sort/__test__/CountingSort.test.js
@@ -27,14 +27,10 @@ describe('CountingSort', () => {
     const sorter = new CountingSort({ visitingCallback });
 
     // Detect biggest number in array in prior.
-    const biggestElement = notSortedArr.reduce((accumulator, element) => {
-      return element > accumulator ? element : accumulator;
-    }, 0);
+    const biggestElement = Math.max(...notSortedArr);
 
     // Detect smallest number in array in prior.
-    const smallestElement = notSortedArr.reduce((accumulator, element) => {
-      return element < accumulator ? element : accumulator;
-    }, 0);
+    const smallestElement = Math.min(...notSortedArr);
 
     const sortedArray = sorter.sort(notSortedArr, smallestElement, biggestElement);