-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DOMPoint»w|x|y|z spec URLs #11167
Conversation
There aren’t actually any #dom-dompoint-w|x|y|z fragment IDs in the https://drafts.fxtf.org/geometry/ spec. Instead the spec has shared text that the DOMPointReadOnly and DOMPoint IDLs both link to, at, e.g., https://drafts.fxtf.org/geometry/#dom-dompointreadonly-x, which says: > The x attribute, on getting, must return the x coordinate value. For > the DOMPoint interface, setting the x attribute must set the x > coordinate to the new value. That is, the first sentence of that shared text applies to both the DOMPointReadOnly and DOMPoint interfaces, while the second sentence applies only to the DOMPoint interface.
Thanks. Good catch. |
@sideshowbarker Shouldn't your amazing fragment tester being added to the CI or to |
Yeah I guess I should open a PR to add it. The source is currently at https://github.com/w3c/mdn-spec-links/blob/master/.check-spec-urls.js and I’m anyway running it regularly as part of building all the https://github.com/w3c/mdn-spec-links data. It takes about 35 seconds to run, so I guess that wouldn’t slow down BCD too much. I should note though the the data it relies on to do its checks is a 19MB list at https://github.com/w3c/mdn-spec-links/blob/master/SPECURLS.json that has every single fragment ID for every single spec that we have any spec URLs for in BCD. The script which builds that It takes about 20 to 25 minutes for that script to (re)build the But I think GitHub Actions has some way to run cron jobs, so I guess I could also set up something that re-builds the |
Yes, I think GitHub Actions can run cron jobs and open issues. See w3c/browser-specs#317 that does this I guess. |
Yes! Sounds like something to outline in a new issue and then implement if we can come up with a good plan for automation. |
There aren’t actually any #dom-dompoint-w|x|y|z fragment IDs in the https://drafts.fxtf.org/geometry/ spec. Instead the spec has shared text that the
DOMPointReadOnly
andDOMPoint
IDLs both link to, at, e.g., https://drafts.fxtf.org/geometry/#dom-dompointreadonly-x, which says:That is, the first sentence of that shared text applies to both the
DOMPointReadOnly
andDOMPoint
interfaces, while the second sentence applies only to theDOMPoint
interface.cc @teoli2003