Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DOMPoint»w|x|y|z spec URLs #11167

Merged
merged 1 commit into from
Jun 21, 2021

Conversation

sideshowbarker
Copy link
Collaborator

There aren’t actually any #dom-dompoint-w|x|y|z fragment IDs in the https://drafts.fxtf.org/geometry/ spec. Instead the spec has shared text that the DOMPointReadOnly and DOMPoint IDLs both link to, at, e.g., https://drafts.fxtf.org/geometry/#dom-dompointreadonly-x, which says:

The x attribute, on getting, must return the x coordinate value. For the DOMPoint interface, setting the x attribute must set the x coordinate to the new value.

That is, the first sentence of that shared text applies to both the DOMPointReadOnly and DOMPoint interfaces, while the second sentence applies only to the DOMPoint interface.

cc @teoli2003

There aren’t actually any #dom-dompoint-w|x|y|z fragment IDs in the
https://drafts.fxtf.org/geometry/ spec. Instead the spec has shared text
that the DOMPointReadOnly and DOMPoint IDLs both link to, at, e.g.,
https://drafts.fxtf.org/geometry/#dom-dompointreadonly-x, which says:

> The x attribute, on getting, must return the x coordinate value. For
> the DOMPoint interface, setting the x attribute must set the x
> coordinate to the new value.

That is, the first sentence of that shared text applies to both the
DOMPointReadOnly and DOMPoint interfaces, while the second sentence
applies only to the DOMPoint interface.
@github-actions github-actions bot added the data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API label Jun 20, 2021
@teoli2003
Copy link
Contributor

Thanks. Good catch.

@teoli2003
Copy link
Contributor

@sideshowbarker Shouldn't your amazing fragment tester being added to the CI or to npm test so that we catch these before it lands? It would be great!

@mdn mdn deleted a comment from Earthman100 Jun 20, 2021
@sideshowbarker
Copy link
Collaborator Author

@sideshowbarker Shouldn't your amazing fragment tester being added to the CI or to npm test so that we catch these before it lands? It would be great!

Yeah I guess I should open a PR to add it.

The source is currently at https://github.com/w3c/mdn-spec-links/blob/master/.check-spec-urls.js and I’m anyway running it regularly as part of building all the https://github.com/w3c/mdn-spec-links data. It takes about 35 seconds to run, so I guess that wouldn’t slow down BCD too much.

I should note though the the data it relies on to do its checks is a 19MB list at https://github.com/w3c/mdn-spec-links/blob/master/SPECURLS.json that has every single fragment ID for every single spec that we have any spec URLs for in BCD.

The script which builds that SPECURLS.json file is at https://github.com/w3c/mdn-spec-links/blob/master/.make-SPECURLS.js

It takes about 20 to 25 minutes for that script to (re)build the SPECURLS.json file — so I don’t run it every day. Instead I only re-build the file whenever the .check-spec-urls.js script reports any errors.

But I think GitHub Actions has some way to run cron jobs, so I guess I could also set up something that re-builds the SPECURLS.json file once a day or so, and checks it back in. That certainly should be often enough.

@teoli2003
Copy link
Contributor

Yes, I think GitHub Actions can run cron jobs and open issues. See w3c/browser-specs#317 that does this I guess.

cc/ @Elchi3 & @ddbeck

@Elchi3
Copy link
Member

Elchi3 commented Jun 21, 2021

Yes! Sounds like something to outline in a new issue and then implement if we can come up with a good plan for automation.

@Elchi3 Elchi3 merged commit 795482e into mdn:main Jun 21, 2021
@sideshowbarker sideshowbarker deleted the sideshowbarker/DOMPoint-spec-urls-fix branch June 21, 2021 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:api 🐇 Compat data for Web APIs. https://developer.mozilla.org/docs/Web/API
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants