Add compat data for input-datetime-local #2200
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Elchi3
added
the
data:html 📄
wbamberg
requested changes
Jun 21, 2018
| "elements": { | ||
| "input": { | ||
| "input-datetime-local": { | ||
| "__compat": { |
There was a problem hiding this comment.
As before, I think this needs:
"description": "<code>type=\"datetime-local\"</code>"
| }, | ||
| "firefox": { | ||
| "version_added": false, | ||
| "notes": "This feature is not implemented yet. See <a href='https://bugzil.la/888320'>bug 888320</a> and <a href='https://wiki.mozilla.org/TPE_DOM/Date_time_input_types'>TPE DOM/Date time input types</a>." |
There was a problem hiding this comment.
I would omit "This feature is not implemented yet." as it is redundant. Also the project page link doesn't seem very active, it's probably better to just link to the bug:
"See <a href='https://bugzil.la/888320'>bug 888320</a>."
wbamberg
reviewed
Jun 21, 2018
| }, | ||
| "safari": { | ||
| "version_added": false, | ||
| "notes": "It is recognized but there is no UI." |
There was a problem hiding this comment.
Oh, and I agree with Daniel's comment on this.
wbamberg
requested changes
Jun 21, 2018
|
Made the changes as requested. Thanks! |
wbamberg
approved these changes
Jun 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://developer.mozilla.org/en-US/docs/Web/HTML/Element/input/datetime-local