Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dates to browsers: opera-android and safari-ios #4558

Closed
wants to merge 2 commits into from

Conversation

shimondoodkin
Copy link

add dates to browsers: opera-android and safari-ios

links of resources used are in commit notes

maybe related: #1951
#2006

tested gave empty result, no browsers without date
bcd = require('mdn-browser-compat-data');

Object.keys(bcd.browsers).map( name=>{ console.log ( name, Object.keys(bcd.browsers[name].releases).reduce((state,ver)=>{var obj=bcd.browsers[name].releases[ver]; obj.version=ver; if(obj.release_date)obj.release_date=new Date(); state.push(obj); return state; },[]).filter((a)=>{ return ! (a.release_date||a.status=='beta'||a.status=='nightly'); return d.getTime()>todate.getTime() }) ) })

@ddbeck ddbeck added the data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation. label Aug 1, 2019
@ddbeck ddbeck self-requested a review August 1, 2019 08:39
Copy link
Collaborator

@ddbeck ddbeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this PR, @shimondoodkin, and welcome to BCD! This is an excellent start to improving this data. I spent a bit of time reviewing the Opera data. I have a few suggestions to refine it, but you did a lot to make that easy to find and double check.

(I didn't have a chance yet to look closely at the Safari data, but I'm running out time to do that today, so I thought I'd share my initial Opera comments now.)

@@ -18,13 +18,14 @@
"engine_version": "2.7"
},
"11.1": {
"release_date": "2011-06-30",
"release_date": "2011-04-11",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The linked release notes are dated June 30 2011; your date appears to be for the desktop release. I think this change can be reverted

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
"release_date": "2011-04-11",
"release_date": "2011-06-30",

"release_notes": "https://dev.opera.com/blog/opera-mobile-11-1-new-features-and-additions/",
"status": "retired",
"engine": "Presto",
"engine_version": "2.8"
},
"11.5": {
"release_date": "2011-06-28",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I couldn't find any citation for this date. Between this press release and some searches, I propose changing this to October 12 2011

Suggested change
"release_date": "2011-06-28",
"release_date": "2011-10-12",

"status": "retired",
"engine": "Blink",
"engine_version": "29"
},
"18": {
"release_date": "2013-09-13",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like the date for a "developer" release of version 18 (maybe a nightly channel?)
https://github.com/operasoftware/devopera/blob/master/src/blog/_posts/2013-09-13-opera-18-developer-and-opera-16-beta-for-android.md

Looks like the final release was on November 20: https://blogs.opera.com/news/2013/11/opera-18-android-tablet/

Suggested change
"release_date": "2013-09-13",
"release_date": "2013-11-20",
"release_notes": "https://blogs.opera.com/news/2013/11/opera-18-android-tablet/",

"status": "retired",
"engine": "Blink",
"engine_version": "28"
},
"16": {
"release_date": "2013-08-26",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to be a little later, September 18 2013

https://web.archive.org/web/20130921055319/http://my.opera.com/chooseopera/blog/2013/09/18/opera-16-for-android-is-released-2

Suggested change
"release_date": "2013-08-26",
"release_date": "2013-09-18",

@@ -51,16 +52,19 @@
"engine_version": "26"
},
"15": {
"release_date": "2013-07-02",
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one looks like another desktop release date. This page suggests July 8 2013

https://blogs.opera.com/news/2013/07/opera-15-for-android/

Suggested change
"release_date": "2013-07-02",
"release_date": "2013-07-08",
"release_notes": "https://blogs.opera.com/news/2013/07/opera-15-for-android/",

@queengooborg
Copy link
Collaborator

Hey @shimondoodkin, do you plan to revisit this PR?

@shimondoodkin
Copy link
Author

I am busy this week. If you like to do the suggested modifications go ahead i am good with it.

@queengooborg
Copy link
Collaborator

Sounds good, thanks for the update! It appears, however, that I do not have the permission to apply the suggestions above -- it's possible the "allow edits from maintainers" checkbox is toggled off?

@shimondoodkin
Copy link
Author

I had toggled that checkbox. thanks

@queengooborg
Copy link
Collaborator

Odd, I’m still not able to apply the suggestions... Ah well, what I’ll probably do is submit a new PR with all suggestions applied, forking this one off so you still get attributed accordingly. 😉

@shimondoodkin
Copy link
Author

shimondoodkin commented Aug 12, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:browsers 🌍 Data about browsers (versions, release dates, etc). This data is used for validation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants