Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Array.prototype.flatten|flattenMap #985

Merged
merged 1 commit into from
Feb 10, 2018
Merged

Add Array.prototype.flatten|flattenMap #985

merged 1 commit into from
Feb 10, 2018

Conversation

Elchi3
Copy link
Member

@Elchi3 Elchi3 commented Feb 9, 2018

Not yet in Chrome or elsewhere https://bugs.chromium.org/p/v8/issues/detail?id=7220
Firefox Nightly only for now: https://bugzilla.mozilla.org/show_bug.cgi?id=1421398

This is another candidate for #338

@Elchi3 Elchi3 added the data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript label Feb 9, 2018
teoli2003
teoli2003 approved these changes Feb 10, 2018
View reviewed changes
Copy link
Contributor

@teoli2003 teoli2003 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, r+

@teoli2003 teoli2003 merged commit 1e154cc into master Feb 10, 2018
@evilpie
Copy link
Contributor

evilpie commented Feb 10, 2018

flattenMap is wrong, it should be flatMap https://tc39.github.io/proposal-flatMap/#sec-Array.prototype.flatMap

@Elchi3 Elchi3 deleted the js-array-flatten branch February 11, 2018 11:31
@Elchi3 Elchi3 mentioned this pull request Feb 11, 2018
Merged
@Elchi3
Copy link
Member Author

Elchi3 commented Feb 11, 2018

Thanks, my bad. Will be corrected in #1009

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teoli2003 teoli2003 teoli2003 approved these changes

Assignees
No one assigned
Labels
data:js 📟 Compat data for JS/ECMAScript features. https://developer.mozilla.org/docs/Web/JavaScript
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Elchi3 @evilpie @teoli2003