Align managed storage snippet with favorite color example #20254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Content:Other
Preview URLsFlawsNone! 🎉 External URLsURL: No new external URLs (this comment was updated 2022-09-07 21:57:30.886659) |
Rob--W
reviewed
Sep 5, 2022
| } | ||
| } | ||
| ``` | ||
|
|
||
| Given this manifest, the "favorite-color-examples\@mozilla.org" extension could access the data using code like this: | ||
| Given this manifest, the ["favourite-colour-examples\@mozilla.org"](https://github.com/mdn/webextensions-examples/tree/master/favourite-colour) extension accesses the data using code like this: |
There was a problem hiding this comment.
"could access" is still accurate. The code snippet below does not appear in that extension.
There was a problem hiding this comment.
Good point, reverted
| } | ||
| } | ||
| ``` | ||
|
|
||
| Given this manifest, the "favorite-color-examples\@mozilla.org" extension could access the data using code like this: | ||
| Given this manifest, the ["favourite-colour-examples\@mozilla.org"](https://github.com/mdn/webextensions-examples/tree/master/favourite-colour) extension accesses the data using code like this: |
There was a problem hiding this comment.
Is the \ before @ needed? If not, let's remove it.
There was a problem hiding this comment.
I changed this just to represent the extension name
Rob--W
approved these changes
Sep 8, 2022
himanshugarg
pushed a commit
to himanshugarg/content
that referenced
this pull request
Sep 27, 2022
* Align managed storage snippet with favorite color example * Addressed feedback * Removed space
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The favourite-colour example web extension uses British English e.g. favourite and colour. The instructions for using the example include details on how to create the manage storage file but also point the reader to storage.managed where the example of the manage storage file is presented in American English e.g. favorite and color. This may be causing issues if the reader uses the storage.managed file version to create the file.
Motivation
To avoid potential issues with the example extension not working if the user copeis the file content from storage.managed.
Supporting details
This issue appears to have occurred in Favourite Color bug manifest #498
Metadata
This PR…