WebExtensions - fix up all the tags except for apis #25117

hamishwillee · 2023-03-06T22:33:41Z

Fixes up all WebExtension tags. Yes, this is a huge PR. But then only one review. I scanned through them all and script still seems to be working well.

Part of mdn/mdn#262

github-actions · 2023-03-06T22:38:20Z

Preview URLs (91 pages)

Flaws (58)

Note! 83 documents with no flaws that don't need to be listed. 🎉

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Modify_a_web_page
Title: Modify a web page
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Mozilla/Add-ons/Add-on_Debugger

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Tips
Title: Tips and Tricks
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Web/JavaScript/New_in_JavaScript/ECMAScript_6_support_in_Mozilla

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/What_are_WebExtensions
Title: What are extensions?
Flaw count: 1

broken_links:
- Can't resolve /en-US/docs/Mozilla/Firefox/Multiprocess_Firefox

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns
Title: Match patterns in extension manifests
Flaw count: 1

broken_links:
- No need for the pathname in anchor links if it's the same page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/dictionaries
Title: dictionaries
Flaw count: 1

bad_bcd_queries:
- No BCD data for query: webextensions.manifest.dictionaries

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Interact_with_the_clipboard
Title: Interact with the clipboard
Flaw count: 2

broken_links:
- Can't resolve /en-US/docs/Web/Guide/HTML/Editable_content
- Can't resolve /en-US/docs/Web/Guide/HTML/Editable_content

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Browser_support_for_JavaScript_APIs
Title: Browser support for JavaScript APIs
Flaw count: 48

macros:
- Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
- Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
- Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
- Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
- Calling the Compat macro with any arguments is deprecated; instead use the 'browser-compat' front-matter key.
- and 43 more flaws omitted

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
Title: Working with files
Flaw count: 3

broken_links:
- Can't resolve /en-US/docs/Web/API/Document/dragenter_event
- Can't resolve /en-US/docs/Web/API/Document/dragover_event
- Can't resolve /en-US/docs/Web/API/Document/drop_event

External URLs (227)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions
Title: Browser Extensions

https://developer.chrome.com/docs/extensions/reference/ (1 time)
https://discourse.mozilla.org/c/add-ons/35 (1 time)
https://extensionworkshop.com/ (2 times)
https://extensionworkshop.com/documentation/develop/debugging/ (1 time)
https://extensionworkshop.com/documentation/develop/differences-between-desktop-and-android-extensions/ (1 time)
https://extensionworkshop.com/documentation/develop/getting-started-with-web-ext/ (1 time)
https://extensionworkshop.com/documentation/develop/porting-a-google-chrome-extension/ (2 times)
https://extensionworkshop.com/documentation/develop/request-the-right-permissions/ (1 time)
https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ (1 time)
https://extensionworkshop.com/documentation/manage/ (1 time)
https://extensionworkshop.com/documentation/publish/ (1 time)
https://extensionworkshop.com/documentation/publish/promoting-your-extension/ (1 time)
https://matrix.to/ (1 time)
https://wiki.mozilla.org/Matrix (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Internationalization
Title: Internationalization

🚨 http://i18njs.com/ (1 time)
https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ (1 time)
https://r12a.github.io/app-subtags/ (1 time)
https://support.mozilla.org/en-US/kb/use-firefox-another-language (1 time)
https://www.mozilla.org/en-US/firefox/channel/desktop/ (1 time)
https://www.mozilla.org/en-US/firefox/new/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Extending_the_developer_tools
Title: Extending the developer tools

https://developer.chrome.com/docs/extensions/mv3/devtools/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Differences_between_API_implementations
Title: Differences between API implementations

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Modify_a_web_page
Title: Modify a web page

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_the_Tabs_API
Title: Working with the Tabs API

https://extensionworkshop.com/documentation/develop/debugging/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Tips
Title: Tips and Tricks

https://babeljs.io/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Intercept_HTTP_requests
Title: Intercept HTTP requests

🚨 http://useragentstring.com/ (3 times)
https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ (2 times)
https://firefox-source-docs.mozilla.org/devtools-user/browser_console/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Implement_a_settings_page
Title: Implement a settings page

https://bugzil.la/1323228 (1 time)
https://extensionworkshop.com/documentation/develop/temporary-installation-in-firefox/ (2 times)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/What_are_WebExtensions
Title: What are extensions?

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Safely_inserting_external_content_into_a_page
Title: Safely inserting external content into a page

https://github.com/cure53/DOMPurify (2 times)
https://handlebarsjs.com/ (1 time)
https://mustache.github.io/ (1 time)
https://owasp.org/www-community/xss-filter-evasion-cheatsheet (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Firefox_workflow_overview
Title: Firefox workflow overview

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Match_patterns
Title: Match patterns in extension manifests

https://en.wikipedia.org/wiki/Fragment_identifier (1 time)
https://en.wikipedia.org/wiki/Query_string (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/What_next_
Title: What next?

https://extensionworkshop.com (1 time)
https://extensionworkshop.com/ (1 time)
https://extensionworkshop.com/community/ (1 time)
https://extensionworkshop.com/documentation/develop/ (1 time)
https://extensionworkshop.com/documentation/develop/browser-extension-development-tools/ (1 time)
https://extensionworkshop.com/documentation/enterprise/ (1 time)
https://extensionworkshop.com/documentation/manage/ (1 time)
https://extensionworkshop.com/documentation/publish/ (1 time)
https://extensionworkshop.com/documentation/publish/add-on-policies/ (1 time)
https://extensionworkshop.com/documentation/publish/firefox-add-on-distribution-agreement/ (1 time)
https://extensionworkshop.com/documentation/publish/recommended-extensions/ (1 time)
https://extensionworkshop.com/documentation/publish/signing-and-distribution-overview/ (1 time)
https://extensionworkshop.com/documentation/publish/source-code-submission/ (1 time)
https://extensionworkshop.com/documentation/themes/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Examples
Title: Example extensions

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Native_messaging
Title: Native messaging

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme
Title: theme

https://bugzil.la/1545109 (1 time)
https://extensionworkshop.com/documentation/publish/signing-and-distribution-overview/ (1 time)
https://play.google.com/store/apps/details?id=org.mozilla.fenix (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version_name
Title: version_name

https://developer.chrome.com/docs/extensions/mv3/manifest/version/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/permissions
Title: permissions

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/theme_experiment
Title: theme_experiment

https://firefox-source-docs.mozilla.org/devtools-user/browser_toolbox/index.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/incognito
Title: incognito

https://support.mozilla.org/en-US/kb/extensions-private-browsing (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/sidebar_action
Title: sidebar_action

https://firefoxux.github.io/StyleGuide/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/browser_specific_settings
Title: browser_specific_settings

https://addons.mozilla.org/ (1 time)
https://addons.mozilla.org/api/v5/applications/firefox/ (1 time)
https://en.wikipedia.org/wiki/Universally_unique_identifier (1 time)
https://extensionworkshop.com/documentation/develop/extensions-and-the-add-on-id/ (2 times)
https://extensionworkshop.com/documentation/manage/updating-your-extension/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/externally_connectable
Title: externally_connectable

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/storage
Title: storage

https://developer.chrome.com/docs/extensions/mv2/manifest/storage/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/protocol_handlers
Title: protocol_handlers

https://support.mozilla.org/en-US/kb/extensions-private-browsing (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/page_action
Title: page_action

https://firefoxux.github.io/StyleGuide/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/chrome_settings_overrides
Title: chrome_settings_overrides

https://www.iana.org/assignments/character-sets/character-sets.xhtml (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/commands
Title: commands

https://bug1303384.bmoattachments.org/attachment.cgi?id=9051647 (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/version
Title: version

https://addons.mozilla.org/ (1 time)
https://developer.chrome.com/docs/extensions/mv3/manifest/version/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/content_security_policy
Title: content_security_policy

https://bugzil.la/1770909 (1 time)
https://example.com (1 time)
https://extensionworkshop.com/documentation/publish/add-on-policies/ (1 time)
Remove object-src from the CSP (at least in MV3) w3c/webextensions#204 (1 time)
https://publicsuffix.org/list/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/options_ui
Title: options_ui

https://design.firefox.com/photon/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/web_accessible_resources
Title: web_accessible_resources

https://extensionworkshop.com/documentation/develop/build-a-secure-extension/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/optional_permissions
Title: optional_permissions

https://bugzil.la/1766026 (1 time)
https://extensionworkshop.com/documentation/develop/request-the-right-permissions/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/host_permissions
Title: host_permissions

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/manifest.json/icons
Title: icons

https://crbug.com/29683 (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface
Title: User interface

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Popups
Title: Popups

https://bugzil.la/1434177 (1 time)
https://design.firefox.com/photon/index.html (1 time)
https://extensionworkshop.com/documentation/develop/debugging/ (1 time)
https://support.mozilla.org/en-US/kb/customize-firefox-controls-buttons-and-toolbars (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Sidebars
Title: Sidebars

https://design.firefox.com/photon/index.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Context_menu_items
Title: Context menu items

https://design.firefox.com/photon/index.html (1 time)
https://design.firefox.com/photon/visuals/iconography.html (1 time)
https://github.com/Rob--W/bookmark-container-tab (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/devtools_panels
Title: devtools panels

https://design.firefox.com/photon/index.html (2 times)
https://design.firefox.com/photon/visuals/iconography.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Notifications
Title: Notifications

https://design.firefox.com/photon/index.html (1 time)
https://design.firefox.com/photon/visuals/iconography.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Options_pages
Title: Options page

https://design.firefox.com/photon/index.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Omnibox
Title: Address bar suggestions

https://searchfox.org/mozilla-central (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_action
Title: Toolbar button

https://design.firefox.com/photon/index.html (1 time)
https://design.firefox.com/photon/visuals/iconography.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Extension_pages
Title: Extension pages

https://design.firefox.com/photon/index.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Page_actions
Title: Address bar button

https://design.firefox.com/photon/index.html (1 time)
https://design.firefox.com/photon/visuals/iconography.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/user_interface/Browser_styles
Title: Browser styles

https://bugzil.la/1465256 (1 time)
https://firefoxux.github.io/StyleGuide/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Your_first_WebExtension
Title: Your first extension

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Build_a_cross_browser_extension
Title: Building a cross-browser extension

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Your_second_WebExtension
Title: Your second extension

🚨 http://www.aha-soft.com/free-icons/free-retina-icon-set/ (1 time)
🚨 http://www.iconbeast.com/faq/ (1 time)
🚨 http://www.iconbeast.com/free/ (1 time)
https://addons.mozilla.org/ (1 time)
https://extensionworkshop.com/documentation/develop/debugging/ (1 time)
https://extensionworkshop.com/documentation/develop/getting-started-with-web-ext/ (1 time)
https://raw.githubusercontent.com/mdn/webextensions-examples/master/beastify/icons/beasts-32.png (1 time)
https://raw.githubusercontent.com/mdn/webextensions-examples/master/beastify/icons/beasts-48.png (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_Security_Policy
Title: Content Security Policy

https://bugzil.la/1581611 (1 time)
https://bugzil.la/1770909 (1 time)
https://crbug.com/896041 (1 time)
https://extensionworkshop.com/documentation/publish/add-on-policies/ (1 time)
Remove object-src from the CSP (at least in MV3) w3c/webextensions#204 (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Developing_WebExtensions_for_Thunderbird
Title: Developing WebExtensions for Thunderbird

https://developer.thunderbird.net/add-ons/about-add-ons (1 time)
https://webextension-api.thunderbird.net/en/latest/ (2 times)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Chrome_incompatibilities
Title: Chrome incompatibilities

https://bugzil.la/1208775 (2 times)
https://bugzil.la/1323433 (1 time)
https://bugzil.la/1435864 (1 time)
https://bugzil.la/1525400 (1 time)
https://bugzil.la/1617479 (1 time)
https://crbug.com/248548 (1 time)
https://crbug.com/328932 (1 time)
https://crbug.com/798169 (1 time)
https://developer.chrome.com/docs/apps/nativeMessaging/ (1 time)
https://developer.chrome.com/docs/extensions/mv3/manifest/key/ (1 time)
https://developer.chrome.com/docs/extensions/reference/declarativeContent/ (1 time)
https://github.com/mozilla/webextension-polyfill (1 time)
https://msdn.microsoft.com/library/windows/desktop/ms684161(v=vs.85).aspx (1 time)
https://msdn.microsoft.com/library/windows/desktop/ms684863(v=vs.85).aspx (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Native_manifests
Title: Native manifests

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Working_with_files
Title: Working with files

https://rpl.github.io/idb-file-storage/ (1 time)
https://rpl.github.io/idb-file-storage/class/src/idb-file-storage.js~IDBFileStorage.html (1 time)
https://rpl.github.io/idb-file-storage/examples/ (1 time)
https://rpl.github.io/idb-file-storage/function/index.html (1 time)
https://www.npmjs.com/package/idb-file-storage (1 time)
https://www.youtube.com/watch?v=t6aVqMMe2Rc&ab_channel=LucaGreco (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Sharing_objects_with_page_scripts
Title: Sharing objects with page scripts

https://firefox-source-docs.mozilla.org/dom/scriptSecurity/xray_vision.html (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Content_scripts
Title: Content scripts

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_contextual_identities
Title: Work with contextual identities

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Firefox_differentiators
Title: Firefox differentiators

https://icons8.com/ (1 time)

URL: /en-US/docs/Mozilla/Add-ons/WebExtensions/Work_with_the_Cookies_API
Title: Work with the Cookies API

https://wiki.mozilla.org/Security/Contextual_Identity_Project/Containers (1 time)

(comment last updated: 2023-03-07 05:01:00)

wbamberg · 2023-03-06T23:38:58Z

@rebloor , I've assigned this to you but if you like I am happy to review it.

wbamberg · 2023-03-07T00:21:05Z

Actually one thing I would say is that this PR adds a lot of non-standard status values, which if we then start using that to drive "non-standard" banners, will mean we will add lots of these banners to the pages, which they don't currently have.

So in this PR we should suppress non-standard.

Note that the BCD does not list these features as non-standard, which is a good thing since it means the automation that keeps status in sync with BCD will not cause this to break.

rebloor · 2023-03-07T01:49:36Z

@wbamberg seems like you might be on the ball with this one. Would you like to finish commenting and reviewing? From my POV your comment about non-standard makes sense. Otherwise, I'm happy to spot-check the changes and approve on that basis. The number of files changed and the impact this has on the performance of the files tab makes much more impractical.

wbamberg · 2023-03-07T01:55:35Z

Thanks @rebloor . I'm happy to review :). But actually I agree about the size of this, because GitHub hides diffs beyond a certain number of files.

@hamishwillee could you split this into say 3 PRs, as well as remove non-standard as mentioned in #25117 (comment) ? (non-standard is weird for WebExtensions, so I think it is OK to omit it).

hamishwillee · 2023-03-07T04:59:19Z

Sure! This is now all the webext except for /api - with "non-standard" removed. There are still some "deprecated". New PRs to follow for APIs.

hamishwillee · 2023-03-07T05:15:19Z

FYI @rebloor @wbamberg

wbamberg

🎉

hamishwillee requested a review from a team as a code owner March 6, 2023 22:33

hamishwillee requested review from jpmedley and removed request for a team March 6, 2023 22:33

github-actions bot added Content:Other Any docs not covered by another "Content:" label Content:WebExt WebExtensions docs labels Mar 6, 2023

hamishwillee mentioned this pull request Mar 6, 2023

[PROJECT] Remove tags from front-matter across mdn/content mdn/mdn#262

Closed

48 tasks

wbamberg requested review from rebloor and removed request for jpmedley March 6, 2023 22:46

WebExt - Remove tags and non-standard except in /api

d9235ac

hamishwillee force-pushed the webext_fixtags branch from 292223b to d9235ac Compare March 7, 2023 04:58

hamishwillee changed the title ~~WebExtensions - fix up all the tags~~ WebExtensions - fix up all the tags except for apis Mar 7, 2023

wbamberg approved these changes Mar 7, 2023

View reviewed changes

wbamberg merged commit d86e14d into mdn:main Mar 7, 2023

hamishwillee deleted the webext_fixtags branch March 9, 2023 23:05

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WebExtensions - fix up all the tags except for apis #25117

WebExtensions - fix up all the tags except for apis #25117

hamishwillee commented Mar 6, 2023

github-actions bot commented Mar 6, 2023 •

edited

Loading

wbamberg commented Mar 6, 2023 •

edited

Loading

wbamberg commented Mar 7, 2023

rebloor commented Mar 7, 2023

wbamberg commented Mar 7, 2023

hamishwillee commented Mar 7, 2023

hamishwillee commented Mar 7, 2023

wbamberg left a comment

WebExtensions - fix up all the tags except for apis #25117

WebExtensions - fix up all the tags except for apis #25117

Conversation

hamishwillee commented Mar 6, 2023

github-actions bot commented Mar 6, 2023 • edited Loading

wbamberg commented Mar 6, 2023 • edited Loading

wbamberg commented Mar 7, 2023

rebloor commented Mar 7, 2023

wbamberg commented Mar 7, 2023

hamishwillee commented Mar 7, 2023

hamishwillee commented Mar 7, 2023

wbamberg left a comment

Choose a reason for hiding this comment

github-actions bot commented Mar 6, 2023 •

edited

Loading

wbamberg commented Mar 6, 2023 •

edited

Loading