Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix spellcheck transclusion #374

Merged
merged 1 commit into from
Dec 17, 2020
Merged

fix spellcheck transclusion #374

merged 1 commit into from
Dec 17, 2020

Conversation

escattone
Copy link
Contributor

Before

image

After

image

@escattone escattone requested a review from a team as a code owner December 17, 2020 21:19
Copy link
Contributor

@peterbe peterbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great!
But I actually brought this up because we ought to do a better way to dealing with the error. At the moment, we just log a flaw and fall back the source input. What we perhaps ought to do is something like:

if (macroExecutionErrorHappened()) {
-  html = source
+ html = `<div class="macro-execution-error" title="An error happened here. Bla bla...">${source}</div>` 
}

and then we can put some CSS on that so it stands out a bit more.
It's just a convoluted and fancy way of getting people involved to help you when they see something.

@escattone escattone merged commit 059859e into mdn:main Dec 17, 2020
@escattone escattone deleted the fix-spellcheck-transclusion branch December 17, 2020 21:25
@escattone
Copy link
Contributor Author

@peterbe Yes, good point. I think we should show something more in these cases.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants