Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add information about ui.systemUsesDarkTheme #4649

Merged
merged 1 commit into from
May 2, 2021
Merged

Add information about ui.systemUsesDarkTheme #4649

merged 1 commit into from
May 2, 2021

Conversation

outloudvi
Copy link
Contributor

What was wrong/why is this fix needed? (quick summary only): Add link about ui.systemUsesDarkTheme for whoever needs it.

MDN URL of main page changed: https://developer.mozilla.org/en-US/docs/Web/CSS/@media/prefers-color-scheme

Issue number (if there is an associated issue): None

Anything else that could help us review it:

MDN was mentioning ui.systemUsesDarkTheme until #2562. However, there is not only Windows, Android, or macOS platform. For Linux (and potentially other) platform user, they don't have a way to set global theme preference. That's when ui.systemUsesDarkTheme can be useful.

Also worth mentioning that mdn/browser-compat-data#9299 once attempted to take it back to BCD, but it does not belong there. (I also agree so, since this is actually more user-centric rather than developer-centric.)

@outloudvi outloudvi requested a review from a team as a code owner May 2, 2021 08:44
@outloudvi outloudvi requested review from mirunacurtean and removed request for a team May 2, 2021 08:44
Copy link
Collaborator

@Ryuno-Ki Ryuno-Ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This sounds like a great information to add!

@Ryuno-Ki Ryuno-Ki merged commit f4aac3a into mdn:main May 2, 2021
@Ryuno-Ki
Copy link
Collaborator

Ryuno-Ki commented May 2, 2021

Thank you, @outloudvi. Welcome to the MDN contributor community 🎉

@Brazuca228
Copy link

𝘿𝙖𝙧𝙠 𝙞𝙩 𝙬𝙞𝙡𝙡 𝙗𝙚 𝙩𝙝𝙚 𝙧𝙞𝙜𝙝𝙩 𝙘𝙤𝙡𝙤𝙧

@outloudvi outloudvi deleted the patch-1 branch May 2, 2021 12:32
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants