Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zh-tw: Make sure localized links are used rather than /en-US/* #14276

Merged
merged 2 commits into from
Jul 16, 2023
Merged

zh-tw: Make sure localized links are used rather than /en-US/* #14276

merged 2 commits into from
Jul 16, 2023

Conversation

queengooborg
Copy link
Collaborator

This PR fixes all of the links within the Traditional Chinese locale so that they no longer point to English content.

@queengooborg queengooborg requested a review from a team as a code owner July 16, 2023 01:19
@queengooborg queengooborg requested review from yin1999 and removed request for a team July 16, 2023 01:19
@github-actions github-actions bot added the l10n-zh Issues related to Chinese content. label Jul 16, 2023
@queengooborg queengooborg mentioned this pull request Jul 16, 2023
Closed
16 tasks
@github-actions
Copy link
Contributor

github-actions bot commented Jul 16, 2023 •
edited
Loading

Preview URLs (11 pages)
Flaws (317)

URL: /zh-TW/docs/Learn/HTML/Multimedia_and_embedding/Other_embedding_technologies
Title: 從物件到iframe - 其他嵌入技術
Flaw count: 189

  • macros:
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Advanced_text_formatting
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Debugging_HTML
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Marking_up_a_letter
    • /zh-TW/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content does not exist but fell back to /en-US/docs/Learn/HTML/Introduction_to_HTML/Structuring_a_page_of_content
    • /zh-TW/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web does not exist but fell back to /en-US/docs/Learn/HTML/Multimedia_and_embedding/Adding_vector_graphics_to_the_Web
    • and 155 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 23 more flaws omitted
  • translation_differences:
    • Differences in the important macros (1 in common of 3 possible)

URL: /zh-TW/docs/Web/API/XMLHttpRequest/Using_XMLHttpRequest
Title: 使用 XMLHttpRequest
Flaw count: 25

  • macros:
    • /zh-TW/docs/Web/API/XMLHttpRequest/open does not exist but fell back to /en-US/docs/Web/API/XMLHttpRequest/open
    • /zh-TW/docs/Web/API/XMLSerializer does not exist but fell back to /en-US/docs/Web/API/XMLSerializer
    • /zh-TW/docs/Web/API/XMLHttpRequest/FormData redirects to /zh-TW/docs/Web/API/FormData
    • /zh-TW/docs/Web/API/XMLHttpRequest/send does not exist but fell back to /en-US/docs/Web/API/XMLHttpRequest/send
    • /zh-TW/docs/Web/API/FileReader/readAsArrayBuffer does not exist but fell back to /en-US/docs/Web/API/FileReader/readAsArrayBuffer
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /docs/Web/HTTP/Status
    • Can't resolve /docs/DOM/XMLHttpRequest/Synchronous_and_Asynchronous_Requests
    • Can't resolve /docs/Web/XPath
    • Can't resolve /docs/Web/Guide/Parsing_and_serializing_XML
    • Can't resolve /docs/Web/API/XMLHttpRequest/HTML_in_XMLHttpRequest
    • and 10 more flaws omitted
  • translation_differences:
    • Differences in the important macros (0 in common of 3 possible)

URL: /zh-TW/docs/Web/API/setInterval
Title: setInterval()
Flaw count: 30

  • macros:
    • /zh-TW/docs/Web/API/Worker does not exist but fell back to /en-US/docs/Web/API/Worker
    • /zh-TW/docs/Web/API/ClearInterval does not exist but fell back to /en-US/docs/Web/API/clearInterval
    • /zh-TW/docs/Web/JavaScript/Reference/eval does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/eval
    • /zh-TW/docs/Web/API/ClearInterval does not exist but fell back to /en-US/docs/Web/API/clearInterval
    • /zh-TW/docs/Web/API/SetTimeout does not exist but fell back to /en-US/docs/Web/API/setTimeout
    • and 7 more flaws omitted
  • broken_links:
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback
    • Can't resolve /files/3997/typewriter.html
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
    • and 11 more flaws omitted
  • heading_links:
    • h2 heading contains an <a> tag
  • translation_differences:
    • Differences in the important macros (3 in common of 4 possible)

URL: /zh-TW/docs/Web/JavaScript/Reference/Errors/Not_defined
Title: ReferenceError: "x" is not defined
Flaw count: 5

  • macros:
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/ReferenceError
    • /zh-TW/docs/Glossary/scope does not exist but fell back to /en-US/docs/Glossary/Scope
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/String/substring does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/String/substring
    • /zh-TW/docs/Glossary/Scope does not exist but fell back to /en-US/docs/Glossary/Scope
  • broken_links:
    • Anchor not lowercase

URL: /zh-TW/docs/Web/JavaScript/Reference/Operators/Destructuring_assignment
Title: 解構賦值
Flaw count: 4

  • macros:
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/SyntaxError
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Anchor not lowercase
    • Can use the English (en-US) link as a fallback

URL: /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/keys
Title: Object.keys()
Flaw count: 9

  • macros:
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyNames does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyNames
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/TypeError does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/TypeError
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/propertyIsEnumerable does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/propertyIsEnumerable
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyNames does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/getOwnPropertyNames
    • /zh-TW/docs/Web/JavaScript/Reference/Global_Objects/Object/values does not exist but fell back to /en-US/docs/Web/JavaScript/Reference/Global_Objects/Object/values
    • and 1 more flaws omitted
  • broken_links:
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
  • translation_differences:
    • Differences in the important macros (2 in common of 3 possible)

URL: /zh-TW/docs/Web/Media/Formats
Title: Media type and format guide: image, audio, and video content
Flaw count: 12

  • macros:
    • /zh-TW/docs/Glossary/codec does not exist but fell back to /en-US/docs/Glossary/Codec
    • /zh-TW/docs/Web/API/MediaStreamTrack does not exist but fell back to /en-US/docs/Web/API/MediaStreamTrack
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-TW/docs/Web/Media/Formats/Images_for_web_designers
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted

URL: /zh-TW/docs/Web/Media/Formats/Containers
Title: Media container formats (file types)
Flaw count: 19

  • macros:
    • /zh-TW/docs/Web/API/MediaStreamTrack does not exist but fell back to /en-US/docs/Web/API/MediaStreamTrack
    • /zh-TW/docs/Web/HTML/Element/source does not exist but fell back to /en-US/docs/Web/HTML/Element/source
    • /zh-TW/docs/Web/HTML/Element/audio does not exist but fell back to /en-US/docs/Web/HTML/Element/audio
    • /zh-TW/docs/Web/HTML/Element/video does not exist but fell back to /en-US/docs/Web/HTML/Element/video
    • /zh-TW/docs/Web/HTML/Element/source does not exist but fell back to /en-US/docs/Web/HTML/Element/source
    • and 3 more flaws omitted
  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Can use the English (en-US) link as a fallback
    • Is currently http:// but can become https://
    • Can use the English (en-US) link as a fallback
    • and 5 more flaws omitted
  • heading_links:
    • h3 heading contains an <a> tag

URL: /zh-TW/docs/Web/Security/Insecure_passwords
Title: 不安全的密碼
Flaw count: 1

  • broken_links:
    • Can use the English (en-US) link as a fallback

URL: /zh-TW/docs/MDN/Writing_guidelines/Howto/Creating_moving_deleting
Title: 編輯以及新增頁面
Flaw count: 11

  • broken_links:
    • Can use the English (en-US) link as a fallback
    • Can't resolve /zh-TW/docs/MDN/Contribute/Editor
    • Anchor not lowercase
    • Anchor not lowercase
    • Anchor not lowercase
    • and 6 more flaws omitted

URL: /zh-TW/docs/Glossary/HTML
Title: HTML
Flaw count: 12

  • macros:
    • /zh-TW/docs/Glossary/World_Wide_Web does not exist but fell back to /en-US/docs/Glossary/World_Wide_Web
    • /zh-TW/docs/Glossary/hypertext does not exist but fell back to /en-US/docs/Glossary/Hypertext
    • /zh-TW/docs/Glossary/IETF does not exist but fell back to /en-US/docs/Glossary/IETF
    • /zh-TW/docs/Glossary/ISO does not exist but fell back to /en-US/docs/Glossary/ISO
    • /zh-TW/docs/Glossary/WHATWG does not exist but fell back to /en-US/docs/Glossary/WHATWG
    • and 4 more flaws omitted
  • broken_links:
    • Can't resolve /zh-TW/Learn/HTML
    • Is currently http:// but can become https://
    • Is currently http:// but can become https://

(comment last updated: 2023-07-16 01:33:29)

yin1999
yin1999 approved these changes Jul 16, 2023
View reviewed changes
Copy link
Member

@yin1999 yin1999 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Let's update the wrong hash in the url

files/zh-tw/web/javascript/reference/errors/not_defined/index.md Outdated Show resolved Hide resolved
@yin1999 yin1999 merged commit eef3785 into main Jul 16, 2023
8 checks passed
@yin1999 yin1999 deleted the zh-tw/localized-links branch July 16, 2023 01:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yin1999 yin1999 yin1999 approved these changes

Assignees
No one assigned
Labels
l10n-zh Issues related to Chinese content.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@queengooborg @yin1999