Updated webpack version in webpack-modules example due to security vulnerabilities #500
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@panasenco given that the read me describes this as a "minimal example of how to use webpack modules so they can be used in a WebExtension. The example package used by this extension is left-pad" doesn't removing left-pad defeat the point of the example? |
…ies in old version.
|
That's a good point, @rebloor... I just force-pushed a version that just updates webpack and does nothing else. Tested in Firefox, seems to work. |
|
Thank you @panasenco, tested myself and all looks OK. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also removed deprecated left-pad dependency.<- Added back in.