Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(search): remove "not" from stopwords #10644

Merged
merged 3 commits into from
Mar 18, 2024
Merged

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 5, 2024

Summary

Problem

The page https://developer.mozilla.org/en-US/docs/Web/CSS/:not cannot be found via full-text search for "not".

Solution

Exclude "not" from the list of stopwords.


Screenshots

Before

image

After

image

How did you test this change?

Deployed to stage and compared with prod, see screenshots above.

@caugner caugner requested a review from a team as a code owner March 5, 2024 11:26
@github-actions github-actions bot added python Pull requests that update Python code deployer Deployment (currently using AWS S3 and AWS Lambda) labels Mar 5, 2024
@caugner caugner added the 🔎 search Search feature label Mar 5, 2024
Copy link
Contributor

@argl argl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets test on staging

@caugner
Copy link
Contributor Author

caugner commented Mar 18, 2024

FYI @argl It works as expected on stage, added screenshots to the PR description.

@caugner caugner merged commit 8fd03c3 into main Mar 18, 2024
14 checks passed
@caugner caugner deleted the remove-not-from-stopwords branch March 18, 2024 14:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deployer Deployment (currently using AWS S3 and AWS Lambda) python Pull requests that update Python code 🔎 search Search feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants