Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(csp): add *.analytics.google.com #10729

Merged
merged 1 commit into from
Mar 18, 2024

Conversation

caugner
Copy link
Contributor

@caugner caugner commented Mar 18, 2024

Summary

Follow-up to #10715.

Problem

GA4 numbers are still not matching with UA, and one explanation could be the omission of *.analytics.google.com in the CSP connect-src directive (although bedrock doesn't have this one).

See: https://developers.google.com/tag-platform/security/guides/csp#google_analytics_4_google_analytics

image

Solution

Add *.analytics.google.com to the `connect-src.


How did you test this change?

We will need to deploy to production to see the effect.

@caugner caugner requested a review from a team as a code owner March 18, 2024 14:48
@caugner caugner merged commit 12dde4f into main Mar 18, 2024
12 checks passed
@caugner caugner deleted the fix-csp-add-analytics-dot-google-dot-com branch March 18, 2024 17:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants