Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(event_loop):make outline&title consistency. #11830

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Cecil0o0
Copy link

Summary

The article, which describes the event loop of javascript language, from project mdn/content, was been titled The event loop. Meanwhile, the relative outline included by sidebar is not.

Problem

The problem is that it could be confused by in-consistency between them above for our readers.

Solution

Before I create a pr for mdn/yari, I created a pr for mdn/content project, this one mdn/content#35836.

I got two helpful tips.

This pr would like to solve the problem, want to improve readability of article by making outline and title consistency for our readers.


Screenshots

Before

image

After

image


How did you test this change?

compare by two screenshots above and recognize differences.

@Cecil0o0 Cecil0o0 requested a review from a team as a code owner September 18, 2024 14:45
@github-actions github-actions bot added the macros tracking issues related to kumascript macros label Sep 18, 2024
@Cecil0o0
Copy link
Author

Cecil0o0 commented Sep 18, 2024

@LeoMcA Hi, could you please have a look at this pr? ^_^ I'm glad to have your reaction or response~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
macros tracking issues related to kumascript macros
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant