-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Translation dashboard #3797
Translation dashboard #3797
Conversation
Note-to-self; The |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow, this is a really nice step forward. I haven't looked at this in detail, but had some early feedback from my local test run.
@Gregoor I don't know if you've had a chance to look yet but I hastily added a feature now so you can filter by differences. For example |
@Gregoor Do you mind if I merge it? I don't want to suck you into a lengthy review for something that's not nearly as important as Markdown. But it would be nice to have a sanity check and a skim-through of some of the code. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quick glance review, but I can't say that it was much more than a skim.
If it serves the translators purposes, I'm all for it, though I find it hard to gauge if the complexity we are taking on here is worth it. I.e. there is some custom search DSL parsing going on here, is that something we can maybe outsource, i.e. are there libraries we could rely on to accomplish this, that would also serve the translators needs?
Just one of the things I was wondering, but yeah like I said, I don't think this can be counted as a proper view yet.
This question is on my mind. We did go into a deep deep tangent on comparing structure with Having said that, as mentioned in Slack/Zoom, I think we should extend the generic So many things we can do. I'd rather merge this and incrementally move forward. Perhaps, from an overall translation quality point of view, the bigger fish to fry is to extend the dashboard to point out which en-US documents have 0 translations in the current chosen locale. That's a feature I'd like to look into next. |
I had it in my head that maybe we should say something on the dashboard itself that reminds users that this dashboard is a bit "beta". It's semi-officially supported because it's merge into |
* translation dashboard server * translation dashboard server * wip * translation dashboard redux * wip * good enough * fix eslint * remove unnecessary LRU caching * adding ability to filter by differences * fix error message styling * remember the chosen sort order * fix naming not in refreshFilters and setInterval in LOading component * no more unnecessary closure functions * space between buttons * simplify API URL
It's a bit of a beast and there are many things we can do but at this point, I'd rather not sink more time into it.
I also don't want to celebrate this as complete and perfect. Instead, I'd like to get this into
main
, ping a couple of savvy translators, and have them play with it.Despite the roughness, this is 10x better than what translators have today, because, they have nothing of this sort.
The idea is that you can start with this to see which translated documents are in the most need to work. I.e. most differences and/or most out-of-date compared the en-US.
The next time to tackle would be to figure out which en-US documents have not been translated yet. That might be a separate table and once that comes in perhaps this current table has to become a "sub-page". I.e. you click "French" and then pick "State of existing translations" or "Documents in need of a first translation".
One thing at a time. But let's get the ball rolling without allowing ourselves to over-engineer this.