Feature: add json output format support #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
nipierre
commented
Mar 31, 2021
nipierre
commented
- Add json output support for more thorough exploitation of data
valnoel
requested changes
Mar 31, 2021
| match input { | ||
| "EBU_TT_D" => Ok(OutputFormat::EbuTtD), | ||
| "JSON" => Ok(OutputFormat::Json), | ||
| _ => Ok(OutputFormat::EbuTtD), |
There was a problem hiding this comment.
Maybe you should log a warning message, to notify the specified format is not supported, don't you think?
| @@ -89,6 +113,9 @@ impl MessageEvent<WorkerParameters> for TranscriptEvent { | |||
| let selected_streams = get_first_audio_stream_id(&format_context)?; | |||
|
|
|||
| let cloned_parameters = parameters; | |||
| let param_output_format = cloned_parameters.output_format.clone(); | |||
|
|
|||
| let output_format = OutputFormat::from_str(&(param_output_format.unwrap_or("JSON".to_string()))).unwrap(); | |||
There was a problem hiding this comment.
So the default output format is JSON here but EBU_TT_D at line 81?
There was a problem hiding this comment.
You should also handle the error instead of "unwrap()"
| OutputFormat::Json => { | ||
| let sequence_index = sequence_number.load(Acquire); | ||
| let message = serde_json::to_string(&event).unwrap_or("".to_string()); | ||
| info!("{:?}", message); |
There was a problem hiding this comment.
The logged message could be more explicit, don't you think? :)
| destination_path: String, | ||
| source_path: String, | ||
| } | ||
|
|
||
| #[derive(Debug, Clone, Deserialize, JsonSchema)] | ||
| enum OutputFormat { |
There was a problem hiding this comment.
Could you define it into a specific file? To lighten the main file...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.