Favouriting feature using matrix account data #131
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ame variable to be descriptive chore: add JSDoc
fix: name variable correctly
refactor: add margin between table sections
… remove redundant variables
…when array is filled
…nd add case for '/explore' bookmarks.
…h filled icon. Add ability to remove favourite directly from the header. chore: add translations
aofn
changed the title
# Conflicts: # assets/_globalCss.css # components/ContextMultiLevelSelect.js # components/UI/ConfirmCancelButtons.js # components/UI/DataList.js # components/UI/PasswordInputButton.js # components/UI/ServiceSubmenu.js # jsconfig.json # package-lock.json # package.json # pages/_app.js # pages/account.js # pages/dashboard/InvitationCard.js # pages/dashboard/KnockCard.js # pages/dashboard/index.js # pages/etherpad/actions/AddExistingPad.js # pages/etherpad/actions/CreateAnonymousPad.js # pages/etherpad/actions/CreateAuthoredPad.js # pages/etherpad/actions/CreatePasswordPad.js # pages/login.js # pages/spacedeck/actions/AddExistingSketch.js # pages/spacedeck/actions/CreateNewSketch.js # prettier.config.js # stylelint.config.js
This is basically re-doing lots of fdc0044#diff-6943349689854874f761d5e14a35b939fe8580aa78fc32725f83f79a96cb0d85 again, which I accidentally reverted in a previous merge w/ master
# Conflicts: # components/UI/DataList.js
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adaptation of #73 using matrix account data to store room id's of spaces.
bookmarkstofavourites