/write: simplify and streamline workflow #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ending on selection. Add headline to component
…ew pad workflow directly.
|
🐛 Assuming that this PR is the culprit: on our current testing environment the "Create new pad" panel does not automatically close anymore, after someone clicked "Create pad". Instead it stays open. Also, I'm missing some whitespace here: |
sort etherpad translations alphabetically and add translation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
fnwbr
requested changes
Mar 12, 2024
|
|
||
| return ( | ||
| <form | ||
| className="mb-8 [&>*+*]:mt-4" |
There was a problem hiding this comment.
Instead of using this selector, how about adding a mt-4 to every component below? I think that would be the more correct "Tailwind"-approach.
| @@ -25,6 +20,16 @@ import logger from '@/lib/Logging'; | |||
| import { isMyPadsApiEnabled, path as etherpadPath } from '@/lib/Etherpad'; | |||
| import { useMatrix } from '@/lib/Matrix'; | |||
| import { useAuth } from '@/lib/Auth'; | |||
| import CreateNewPad from './actions/CreateNewPad'; | |||
|
|
|||
| const Header = styled.header` | |||
There was a problem hiding this comment.
Can we use Tailwind instead of making these two new styled components?
|
Also, when the MyPads API is not enabled in the config, we still show the user the password inputs: Clicking on "Create pad" errors: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #130