Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove "Matrix Content Storage" #44

Merged
merged 3 commits into from
Aug 25, 2023
Merged

Remove "Matrix Content Storage" #44

merged 3 commits into from
Aug 25, 2023

Conversation

fnwbr
Copy link
Member

@fnwbr fnwbr commented Aug 25, 2023

We can always bring this back if we decide otherwise. But at the moment this is unused and we don't have a plan for actually making use of it.

At the same time removing this option reduces the complexity of Matrix.js by a lot.

@fnwbr fnwbr merged commit e9ae29f into main Aug 25, 2023
1 check passed
@fnwbr fnwbr deleted the remove-content-storage branch August 25, 2023 17:52
github-advanced-security[bot]
github-advanced-security bot found potential problems Aug 25, 2023
View reviewed changes
lib/Matrix.js
const [applicationsFolder, setApplicationsFolder] = useState('');
const [serviceSpaces, setServiceSpaces] = useState({});

const buildRoomObject = useCallback((roomId) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
});
}, [buildRoomObject, rooms]);
});
}, [buildRoomObject, rooms]);

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback has a missing dependency: 'setRoom'. Either include it or remove the dependency array.
lib/Matrix.js
setDirectMessages(deleteElement(room.roomId));
}
//@TODO setRoomContents(setMessages(room.roomId));
const RoomMyMembershipEvent = useCallback((room, membership, prevMembership) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
}
});

const AccountDataEvent = useCallback((event) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
hydrateDirectMessages(event.getContent());
});

const RoomTimelineEvent = useCallback((event, room) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
}
});

const RoomReceiptEvent = useCallback((event, room) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
}
});

const SyncEvent = useCallback((newState, prevState) => {

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useCallback does nothing when called with only one argument. Did you forget to pass an array of dependencies?
lib/Matrix.js
matrixClient.off('Room.receipt', RoomReceiptEvent);
matrixClient.off('sync', SyncEvent);
};
}, []);

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useEffect has missing dependencies: 'AccountDataEvent', 'RoomMyMembershipEvent', 'RoomReceiptEvent', 'RoomTimelineEvent', 'SyncEvent', and 'matrixClient'. Either include them or remove the dependency array.
lib/Matrix.js
logger.debug('Found "Applications" space', { existingApplicationsSpace });
setApplicationsFolder(existingApplicationsSpace.roomId);
initialSyncDone && lookForApplicationsFolder();
}, [initialSyncDone]);

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useEffect has missing dependencies: 'createRoom' and 'spaces'. Either include them or remove the dependency array.
lib/Matrix.js
applicationsFolder && lookForServiceSpaces();
}, [applicationsFolder]);
applicationsFolder && lookForServiceSpaces();
}, [applicationsFolder]);

Check failure

Code scanning / ESLint

verifies the list of dependencies for Hooks like useEffect and similar Error

React Hook useEffect has missing dependencies: 'authenticationProvider', 'createRoom', and 'spaces'. Either include them or remove the dependency array.
@fnwbr fnwbr mentioned this pull request Aug 30, 2023
Merged
2 tasks
aofn pushed a commit that referenced this pull request Aug 30, 2023
remove unnecessary parameter, see #44
c0cbfd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fnwbr