Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow up to #36 Fix textsize fonticonsize #37

Merged
merged 3 commits into from
Sep 25, 2015

Conversation

squeeish
Copy link

Following up from #36:

@squeeish oops,
we missed the right unit, we should use Sp unit instead of Dp. Could you fix it ?
Make sure you implement the converter also for Fancybuttons setters like setTextSize(int)
Please update the sample project too.
Thanks

Done!

Terence Yeong added 3 commits September 25, 2015 01:05
Updated sample project to account for changes in library
Updated README.md to reflect new screenshots and slightly modified code for programmatically created Facebook button
medyo added a commit that referenced this pull request Sep 25, 2015
Follow up to #36 Fix textsize fonticonsize
@medyo medyo merged commit c7cf7bc into medyo:master Sep 25, 2015
@medyo
Copy link
Owner

medyo commented Sep 25, 2015

Perfect, Thanks @squeeish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants