handle traceback better and fix broken test

meedan · Jul 4, 2024 · 346e596 · 346e596
1 parent ed7512f
commit 346e596
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 3 deletions.
diff --git a/lib/model/model.py b/lib/model/model.py
@@ -1,3 +1,4 @@
+import traceback
 from typing import Union, List, Dict, Any
 from abc import ABC, abstractmethod
 import os
@@ -46,7 +47,10 @@ def handle_fingerprinting_error(self, e):
         error_context = {"error": str(e)}
         for attr in ["__cause__", "__context__", "args", "__traceback__"]:
             if attr in dir(e):
-                error_context[attr] = getattr(e, attr)
+                if attr == "__traceback__":
+                    error_context[attr] = '\n'.join(traceback.format_tb(getattr(e, attr)))
+                else:
+                    error_context[attr] = getattr(e, attr)
         capture_custom_message("Error during fingerprinting for {self.model_name}", 'info', error_context)
         return schemas.ErrorResponse(error=str(e), error_details=error_context)
 

diff --git a/test/lib/queue/test_queue.py b/test/lib/queue/test_queue.py
@@ -247,8 +247,8 @@ def test_error_capturing_in_get_response(self, mock_cache_set, mock_cache_get):
 
         self.assertIsInstance(result, schemas.ErrorResponse)
         self.assertEqual(result.error, "Test error")
-        self.assertIn("exception", result.error_details)
-        self.assertEqual(result.error_details["exception"], "Test error")
+        self.assertIn("error", result.error_details)
+        self.assertEqual(result.error_details["error"], "Test error")
 
 if __name__ == '__main__':
     unittest.main()