Cv2 4606 delete message #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ted-count messages
skyemeedan
reviewed
May 22, 2024
| @@ -144,4 +144,5 @@ def increment_message_error_counts(self, messages_with_queues: List[Tuple]): | |||
| else: | |||
| updated_message = schemas.parse_message(message_body) | |||
| updated_message.retry_count = retry_count | |||
| queue.delete_messages(Entries=[self.delete_message_entry(message)]) | |||
There was a problem hiding this comment.
this isn't including the idx (which is mapped to the id) is it needed?
There was a problem hiding this comment.
yep - idx is only needed as some unique identifier in a list of items - and on the other side of this, it just defaults to 0 if not passed along, so this works fine!
lol, yep - and yes I did test this on the QA box directly to make sure that message deletion would work, as I was figuring out what the error was in this latest deploy |
skyemeedan
approved these changes
May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If we don't delete the existing message this code just has the net effect of compounding the same task repeatedly which is definitely not what we want! Increment the count, delete the old job, and add a new job.