Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CV2-4855 move Dockerfile requirements to requirements.txt #94

Merged
merged 4 commits into from
Jul 4, 2024

Conversation

DGaffney
Copy link
Collaborator

@DGaffney DGaffney commented Jul 2, 2024

Description

Pin all pip install versions to reduce dependency thrashing

Reference: CV2-4855

How has this been tested?

Not tested locally - need to watch CI to see if it just builds at all with these changes, or if we had these installs outside the requirements.txt for a reason

Are there any external dependencies?

None

Have you considered secure coding practices when writing this code?

None

@DGaffney
Copy link
Collaborator Author

DGaffney commented Jul 2, 2024

@skyemeedan appears to build fine... maybe that's enough? I suggest you try building from this branch tomorrow and reporting back?

@skyemeedan
Copy link
Contributor

skyemeedan commented Jul 3, 2024

for me this is failing for Audio

 => ERROR [audio 17/19] RUN pip install --no-cache-dir -r requirements.txt 
...
557.1 Successfully built pyacoustid sentence-transformers tmkpy fasttext
557.9 Installing collected packages: tokenizers, tmkpy, sentencepiece, rfc3986, zipp, wrapt, websockets, uvloop, urllib3, typing-extensions, tqdm, tomli, threadpoolctl, tabulate, sniffio, six, regex, pyyaml, python-dotenv, pycparser, pybind11, psutil, protobuf, pluggy, pillow, packaging, opentelemetry-semantic-conventions, nvidia-cuda-runtime-cu11, nvidia-cuda-nvrtc-cu11, nvidia-cublas-cu11, numpy, networkx, multidict, langcodes, joblib, jmespath, jellyfish, iniconfig, idna, httptools, h11, filelock, exceptiongroup, click, charset-normalizer, certifi, audioread, async-timeout, annotated-types, yarl, uvicorn, sentry-sdk, segtok, scipy, requests, redis, python-dateutil, pytest, pydantic-core, opentelemetry-proto, nvidia-cudnn-cu11, nltk, importlib-metadata, googleapis-common-protos, fasttext, deprecated, cffi, anyio, yake, watchfiles, torch, starlette, scikit-learn, pydantic, pyacoustid, opentelemetry-exporter-otlp-proto-common, opentelemetry-api, huggingface-hub, httpcore, botocore, transformers, torchvision, s3transfer, opentelemetry-sdk, httpx, fastapi, sentence-transformers, pact-python, opentelemetry-exporter-otlp-proto-http, boto3
569.4 ERROR: Could not install packages due to an OSError: [Errno 5] Input/output error

I'll clearing docker cache and then try building without audio

@skyemeedan
Copy link
Contributor

This worked! (just needed to clear a bunch of disk space from all the failed builds)

@DGaffney DGaffney merged commit b1084d2 into master Jul 4, 2024
2 checks passed
@DGaffney DGaffney deleted the cv2-4855-dependencies branch July 4, 2024 13:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants