[translation] Chinese (Traditional) #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YWJamesLin
changed the title
adlk
reviewed
Oct 26, 2017
| @@ -10,4 +10,5 @@ module.exports = { | |||
| pl: 'Polish', | |||
| ru: 'Русский', | |||
| ua: 'Українська', | |||
| 'zh-Hant': 'Chinese (Traditional)', | |||
There was a problem hiding this comment.
I'm trying to figure out what would be the best and consistent way to display non-Latin languages in the language selection. Does it make sense to display a language like Chinese, Russian, Greek, Ukrainian, Thai, ... in English? Should we do both? Should we just use the respected language?
What would be your preferred way when you see a language selection?
There was a problem hiding this comment.
reference: PR #69 merged. I think it's better to keep language key in English due to consistency with other language keys.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Chinese (Traditional) Translation
Description
languages.js [Updated] add zh-Hant
zh-Hant.json Created with translations
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist:
$ yarn lint).