Update electron-spellchecker dependency #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I had the problem described in the referenced issue. Pulled down this PR and got everything sorted so I could build 👍 Thanks @dannyqiu |
adlk
approved these changes
Oct 30, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix build on High Sierra
Description
Running
yarn add global gulp-cli@1.2.2andyarn add global gulpjs/gulp#4.0throws build exception as referenced here.Bumps up version in
yarn.lockto v4.0.6 (< v4.0.5 has issues)Motivation and Context
Fixes build on High Sierra, without having to manually change files in dependencies.
How Has This Been Tested?
Rebuild
Screenshots (if appropriate):
Types of changes