Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PR] Fix empty strings in service menu #301

Merged
merged 2 commits into from
Nov 18, 2017
Merged

Conversation

adlk
Copy link
Contributor

@adlk adlk commented Nov 18, 2017

When a service is configured without a name the service app menu will show an empty item. We fallback to the recipe name including the team id or custom Url.

Closes #250

@adlk adlk changed the title Fix empty strings in service menu [PR] Fix empty strings in service menu Nov 18, 2017
@adlk adlk merged commit f5d6d03 into develop Nov 18, 2017
@adlk adlk deleted the feature/250-service-menu branch November 27, 2017 12:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant