Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tab cycling with ctrl[+shift]+tab or ctrl+[pageup|pagedown] #37

Merged
merged 3 commits into from
Oct 22, 2017

Conversation

GustavoKatel
Copy link
Contributor

This is related to #35

Description

This PR adds the following key bindings:

  • ⌘+pagedown, ctrl+pagedown, ⌘+shift+tab, ctrl+shift+tab: set active the next service
  • ⌘+pageup, ctrl+pageup, ⌘+tab, ctrl+tab: set active the previous service

This is not set in stone. These settings are comfortable to me, but I am free to discuss the semantics of each key-binding.

Motivation and Context

Since this feature exists in Franz 4 and it makes Franz 5 UX richer, I don't see why not 😛

How Has This Been Tested?

OS: Linux Mint 18.2 (Ubuntu 16.04)
I cannot test on others environment. Can you guys help me with this?

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • [x ] New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project (run $ yarn lint).

@adlk adlk changed the base branch from master to develop October 20, 2017 08:54
@GustavoKatel
Copy link
Contributor Author

GustavoKatel commented Oct 20, 2017

Just noticed now that it was cycling through disabled services as well, which are not mount by react, therefore causing an error. All fixed.

@adlk adlk merged commit 982c970 into meetfranz:develop Oct 22, 2017
@tobiasdueser
Copy link

Wouldn't it be more intuitive if ctrl+tab would cycle down and ctrl+tab+shift up? Like the direction of reading: left to right and top to bottom.

@GustavoKatel
Copy link
Contributor Author

This is tricky @tobiasdueser 😃 It seems more intuitive to me that way. If this is a deal-breaker and since this PR is merged, you could open an issue with a feature request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants