Title bar for Windows & Linux #759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
override `reset.scss` with `title-bar.scss`
[MINOR] REFACTOR rename `FRANZ_PLATFORM` to `OS_PLATFORM` [MINOR] FIX propTypes for `electron-react-titlebar`
tested on macOS
2 tasks
adlk
changed the title
adlk
requested changes
Mar 2, 2018
adlk
approved these changes
Mar 2, 2018
adlk
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There is now a fancy new title bar for Windows & Linux users similar to Github for Desktop and menu items are finally internationalized!
Motivation and Context
Lots of users had issues with the hidden menu bar on Windows and / or don't wanna waste precious vertical screen estate. A new frameless Franz provides a cleaner, fresh user experience.
Todos:
Types of changes
Checklist:
$ yarn lint).