Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove leading whitespace from filenames #105

Merged
merged 2 commits into from
May 21, 2024
Merged

remove leading whitespace from filenames #105

merged 2 commits into from
May 21, 2024

Conversation

vintagesucks
Copy link
Contributor

Both CONTRIBUTING.md and LICENSE.md, which are linked from the README, currently return 404 because the filenames contain leading whitespace.

Example CONTRIBUTING.md:

grafik

Note: Both files are also empty, but I didn't want to include a README change to fix the LICENSE link in this PR as well.

@mehrancodes mehrancodes added the enhancement New feature or request label May 19, 2024
@mehrancodes
Copy link
Owner

@vintagesucks Thank you so much for taking care of it! Could I ask you to update their content with the proper information too?

@vintagesucks
Copy link
Contributor Author

@mehrancodes I have taken care of the duplicate licence file, but I don't think the creation of contribution guidelines is something I can do for you.

Copy link

@jotaesteves jotaesteves left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for contributing
fyi @mehrancodes 👍

Copy link
Owner

@mehrancodes mehrancodes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Let's merge it.

@mehrancodes mehrancodes merged commit a35cd56 into mehrancodes:main May 21, 2024
1 check passed
@vintagesucks vintagesucks deleted the leading-whitespace branch May 21, 2024 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants