Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(templates): Drop support for Python 3.8 in templates #2661

Merged
merged 1 commit into from
Sep 26, 2024

Conversation

edgarrmondragon
Copy link
Collaborator

@edgarrmondragon edgarrmondragon commented Sep 11, 2024

Python 3.8 will reach EOL in about one month, so arguably there's no need for new plugins to support it.


📚 Documentation preview 📚: https://meltano-sdk--2661.org.readthedocs.build/en/2661/

@edgarrmondragon edgarrmondragon requested a review from a team as a code owner September 11, 2024 14:59
@edgarrmondragon edgarrmondragon marked this pull request as draft September 11, 2024 14:59
Copy link

codecov bot commented Sep 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 90.20%. Comparing base (3d3ac7b) to head (60a550b).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2661      +/-   ##
==========================================
- Coverage   90.24%   90.20%   -0.05%     
==========================================
  Files          58       58              
  Lines        4891     4891              
  Branches      963      963              
==========================================
- Hits         4414     4412       -2     
- Misses        329      331       +2     
  Partials      148      148              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/drop-py38-templates branch from af3b948 to 55068b8 Compare September 11, 2024 15:15
@edgarrmondragon edgarrmondragon added this to the v0.42.0 milestone Sep 11, 2024
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/drop-py38-templates branch 2 times, most recently from 621577a to 1930fe4 Compare September 11, 2024 16:22
@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/drop-py38-templates branch 3 times, most recently from f45bfd0 to e46b319 Compare September 26, 2024 18:29
Copy link

codspeed-hq bot commented Sep 26, 2024

CodSpeed Performance Report

Merging #2661 will not alter performance

Comparing edgarrmondragon/feat/drop-py38-templates (e46b319) with main (e997deb)

Summary

✅ 6 untouched benchmarks

@edgarrmondragon edgarrmondragon force-pushed the edgarrmondragon/feat/drop-py38-templates branch from e46b319 to 265c165 Compare September 26, 2024 18:33
@edgarrmondragon edgarrmondragon marked this pull request as ready for review September 26, 2024 18:36
@edgarrmondragon edgarrmondragon merged commit f1e8114 into main Sep 26, 2024
33 checks passed
@edgarrmondragon edgarrmondragon deleted the edgarrmondragon/feat/drop-py38-templates branch September 26, 2024 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant