Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix release filtering and RBAC for releases #1023

Merged
merged 1 commit into from
May 28, 2024

Conversation

kjaskiewiczz
Copy link
Contributor

With the old implementation, when using more than one tag in the filter, or when using role which grants access to releases with given tag (and more than one tag was specified), deployments will present only releases containg ALL the tags each.
With the new behavior, deployments will retrun all the releases containg ANY of the tags.

Ticket: MEN-7272

With the old implementation, when using more than one tag in the filter,
or when using role which grants access to releases with given tag (and more
than one tag was specified), deployments will present only releases
containg ALL the tags each.
With the new behavior, deployments will retrun all the releases containg
ANY of the tags.

Changelog: All
Ticket: MEN-7272

Signed-off-by: Krzysztof Jaskiewicz <krzysztof.jaskiewicz@northern.tech>
@mender-test-bot
Copy link

mender-test-bot commented May 27, 2024

Merging these commits will result in the following changelog entries:

Changelogs

deployments (men-7272)

New changes in deployments since master:

Bug Fixes
  • fix release filtering and RBAC for releases

    With the old implementation, when using more than one tag in the filter,
    or when using role which grants access to releases with given tag (and more
    than one tag was specified), deployments will present only releases
    containg ALL the tags each.
    With the new behavior, deployments will retrun all the releases containg
    ANY of the tags.
    (MEN-7272)

@mender-test-bot
Copy link

@kjaskiewiczz, Let me know if you want to start the integration pipeline by mentioning me and the command "start pipeline".


my commands and options

You can trigger a pipeline on multiple prs with:

  • mentioning me and start pipeline --pr mender/127 --pr mender-connect/255

You can start a fast pipeline, disabling full integration tests with:

  • mentioning me and start pipeline --fast

You can trigger GitHub->GitLab branch sync with:

  • mentioning me and sync

You can cherry pick to a given branch or branches with:

  • mentioning me and:
 cherry-pick to:
 * 1.0.x
 * 2.0.x

@kjaskiewiczz
Copy link
Contributor Author

@mender-test-bot start pipeline --fast

@mender-test-bot
Copy link

Hello 😺 I created a pipeline for you here: Pipeline-1307447514

Build Configuration Matrix

Key Value
AUDITLOGS_REV master
BUILD_CLIENT false
CREATE_ARTIFACT_WORKER_REV master
DEPLOYMENTS_ENTERPRISE_REV master
DEPLOYMENTS_REV pull/1023/head
DEVICEAUTH_ENTERPRISE_REV master
DEVICEAUTH_REV master
DEVICECONFIG_REV master
DEVICECONNECT_REV master
DEVICEMONITOR_REV master
GENERATE_DELTA_WORKER_REV master
GUI_REV master
INTEGRATION_REV master
INVENTORY_ENTERPRISE_REV master
INVENTORY_REV master
IOT_MANAGER_REV master
MENDER_ARTIFACT_REV master
MENDER_BINARY_DELTA_REV master
MENDER_CLI_REV master
MENDER_CONFIGURE_MODULE_REV master
MENDER_CONNECT_REV master
MENDER_CONVERT_REV master
MENDER_GATEWAY_REV master
MENDER_REV master
MENDER_SETUP_REV master
MENDER_SNAPSHOT_REV master
MONITOR_CLIENT_REV master
RUN_BACKEND_INTEGRATION_TESTS true
RUN_INTEGRATION_TESTS false
TENANTADM_REV master
USERADM_ENTERPRISE_REV master
USERADM_REV master
WORKFLOWS_ENTERPRISE_REV master
WORKFLOWS_REV master

@kjaskiewiczz kjaskiewiczz merged commit 9c3ec95 into mendersoftware:master May 28, 2024
10 checks passed
@mender-test-bot
Copy link

Hello 😺 This PR contains changelog entries. Please, verify the need of backporting it to the following release branches:
4.6.x (release 3.7.x) - 🤖 🍒
4.5.x (release 3.6.x)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants