Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: fix typo "were ran" vs "were run" typo #737

Merged
merged 1 commit into from
Mar 12, 2024
Merged

chore: fix typo "were ran" vs "were run" typo #737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion __tests__/e2e/smoke.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ mergeable:
{
title: '1/1 Fail(s): TITLE',
summary:
'### Status: FAIL\n\n Here are some stats of the run:\n 1 validations were ran.\n 0 PASSED\n 1 FAILED\n ',
'### Status: FAIL\n\n Here are some stats of the run:\n 1 validations were run.\n 0 PASSED\n 1 FAILED\n ',
text:
'#### :x: Validator: TITLE\n * :heavy_check_mark: ***title must exclude \'must_be_excluded_text\'***\n Input : [WIP] Test3\n Settings : ```{"must_exclude":{"regex":"must_be_excluded_text"}}```\n * :x: ***title does not include "must_be_included_text"***\n Input : [WIP] Test3\n Settings : ```{"must_include":{"regex":"must_be_included_text"}}```\n * :x: ***title must begins with "begins_with_text"***\n Input : [WIP] Test3\n Settings : ```{"begins_with":{"match":"begins_with_text"}}```\n * :x: ***title must end with "ends_with_text"***\n Input : [WIP] Test3\n Settings : ```{"ends_with":{"match":"ends_with_text"}}```\n * :x: ***(title must begins with "begins_with_text" ***AND*** title must end with "ends_with_text")***\n Input : [WIP] Test3\n Settings : ```{"and":[{"begins_with":{"match":"begins_with_text"}},{"ends_with":{"match":"ends_with_text"}}]}```\n * :x: ***(title does not include "must_be_included_text" ***OR*** title must begins with "begins_with_text")***\n Input : [WIP] Test3\n Settings : ```{"or":[{"must_include":{"regex":"must_be_included_text"}},{"begins_with":{"match":"begins_with_text"}}]}```\n<!-- #mergeable-data {"id":4,"eventName":"pull_request","action":"edited"} #mergeable-data -->'
},
Expand Down
6 changes: 3 additions & 3 deletions docs/actions/check.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ Check
status: 'success' # Can be: success, failure, neutral, cancelled, timed_out, or action_required
payload:
title: 'Mergeable Run have been Completed!'
summary: "All the validators have returned 'pass'! \n Here are some stats of the run: \n {{validationCount}} validations were ran"
summary: "All the validators have returned 'pass'! \n Here are some stats of the run: \n {{validationCount}} validations were run"

You can pass in Handlebars template to show the details result of the run.

Expand All @@ -26,7 +26,7 @@ You can pass in Handlebars template to show the details result of the run.
summary: |
### Status: {{toUpperCase validationStatus}}
Here are some stats of the run:
{{validationCount}} validations were ran.
{{validationCount}} validations were run.
{{passCount}} PASSED
{{failCount}} FAILED
text: "{{#each validationSuites}}\n
Expand All @@ -46,7 +46,7 @@ You can pass in Handlebars template to show the details result of the run.
summary: |
### Status: {{toUpperCase validationStatus}}
Some or All of the validators have returned 'error' status, please check below for details
Here are some stats of the run: \n {{validationCount}} validations were ran.
Here are some stats of the run: \n {{validationCount}} validations were run.
{{passCount}} ***PASSED***
{{failCount}} ***FAILED***
{{errorCount}} ***ERRORED***
Expand Down
8 changes: 4 additions & 4 deletions lib/configuration/lib/consts.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ module.exports = {
status: 'success',
payload: {
title: 'Mergeable Run has been Completed!',
summary: 'All the validators have returned \'pass\'! \n Here are some stats of the run: \n {{validationCount}} validations were ran'
summary: 'All the validators have returned \'pass\'! \n Here are some stats of the run: \n {{validationCount}} validations were run'
}
}],
DEFAULT_PR_FAIL: [{
Expand All @@ -19,7 +19,7 @@ module.exports = {
summary: `### Status: {{toUpperCase validationStatus}}

Here are some stats of the run:
{{validationCount}} validations were ran.
{{validationCount}} validations were run.
{{passCount}} PASSED
{{failCount}} FAILED
`,
Expand All @@ -42,7 +42,7 @@ module.exports = {
Some or All of the validators have returned 'error' status, please check below for details

Here are some stats of the run:
{{validationCount}} validations were ran.
{{validationCount}} validations were run.
{{passCount}} ***PASSED***
{{failCount}} ***FAILED***
{{errorCount}} ***ERRORED***`,
Expand All @@ -62,7 +62,7 @@ Status {{toUpperCase status}}
DEFAULT_ISSUES_PASS: [{
do: 'comment',
payload: {
body: 'All the validators have returned \'pass\'! \n Here are some stats of the run: \n {{validationCount}} validations were ran'
body: 'All the validators have returned \'pass\'! \n Here are some stats of the run: \n {{validationCount}} validations were run'
}
}],
DEFAULT_ISSUES_FAIL: [{
Expand Down
Loading