Bugfix: sanitize_dir: use pathlib to handle case-insensitive filesystems #6398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update unit test since /someabs is NOT absolute path on Windows
scivision
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #6395
The unit tests needed to be updated to accurately reflect Windows path behavior. The prior method was fine for Posix-like filesystems, but conflicted with the distinct behavior of Windows paths respected in Python pathlib. This issue creeps up from time to time as we continue to implement pathlib inside Meson, this is just one step in that transition.
d31cbf6 was just an obvious change for unreachable/dead code I happened across.
I would suggest squashing these commits if desired, either way is fine. I just left them unsquashed to show the various steps needed to remove always-Posix assumptions from the relevant code.