fix compiler flag order on visual studio #6735
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
currently, all "-LIBPATH:..." arguments are treated as gcc's -L, so they are prependded they end up before the '/link' argument, so they are ignored
|
Unit test? This will break very easily otherwise :) |
|
Unfortunately it's not the correct solution, it breaks non C compilers which don't have the linker_to_compiler_args method. |
|
this problem seems solved in recent meson version |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
currently, all "-LIBPATH:..." arguments are treated as gcc's -L, so they are prependded
they end up before the '/link' argument, so they are ignored