Adds markdown-link-check and fixes a broken link #165
Conversation
Signed-off-by: Adrian Cole <adrian.cole@elastic.co>
codefromthecrypt
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
| rev: v3.11.2 | ||
| hooks: | ||
| - id: markdown-link-check | ||
| args: ['--quiet'] |
There was a problem hiding this comment.
This isn't really related to your PR since you're just adding to where these checks are already, but it would be nice to add all of this to CI using github actions. If the maintainers support it, I can file an issue to track it.
There was a problem hiding this comment.
This feels like it is related to the PR? The title says they are adding a link check.
There was a problem hiding this comment.
Sorry, my comment wasn't clear. I mean MY comment isn't related to the PR. In other words, I'm not suggesting this PR should change, but just sharing a thought for the future (that we should also run these checks in CI)
There was a problem hiding this comment.
Ohhh! yes, absolutely. Let's file an issue for it. We have CI landing shortly on this repository but having an issue to make sure we don't forget this specific bit would be useful.
There was a problem hiding this comment.
Filed #172 to come back and see if all the pre-commit checks are running in CI at some point
| pip_packages=[ | ||
| "boto3" | ||
| ], | ||
| pip_packages=["boto3"], |
There was a problem hiding this comment.
It looks like you have a couple of Python changes (this one and another in augment_messages.py) that are unrelated to markdown linting.
There was a problem hiding this comment.
Yeah I think it just feels like they ran pre-commit and ended up doing formatting. Seems OK.
| pip_packages=[ | ||
| "boto3" | ||
| ], | ||
| pip_packages=["boto3"], |
There was a problem hiding this comment.
Yeah I think it just feels like they ran pre-commit and ended up doing formatting. Seems OK.
| rev: v3.11.2 | ||
| hooks: | ||
| - id: markdown-link-check | ||
| args: ['--quiet'] |
There was a problem hiding this comment.
This feels like it is related to the PR? The title says they are adding a link check.
|
thanks for resolving this on own! cheers |
Note the image here is a bad link, but I don't have content for it:
2.4 Prompt Format
You can even run
llama model prompt-formatsee all of the templates and their tokens: