inference: Add model option to client #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
russellb
requested review from
ashwinb,
yanxi0830,
hardikjshah,
dltn and
raghotham
as code owners
facebook-github-bot
added
the
CLA Signed
russellb
force-pushed
the
inference-client-model-choice
branch
from
d58b2b6
to
1499006
Compare
ashwinb
approved these changes
Oct 2, 2024
llama_stack/apis/inference/client.py
Outdated
| messages=[message], | ||
| stream=stream, | ||
| ) | ||
| async for log in EventLogger().log(iterator): | ||
| log.print() | ||
|
|
||
|
|
||
| async def run_mm_main(host: str, port: int, stream: bool, path: str): | ||
| async def run_mm_main(host: str, port: int, stream: bool, path: str, model: str): |
There was a problem hiding this comment.
nit: (also existing issue) -- the typehint for both path and model should be Optional[str]
There was a problem hiding this comment.
yeah, I noticed a warning because of that. I can go ahead and fix it here.
There was a problem hiding this comment.
@ashwinb added a fix for that to this PR
ashwinb
reviewed
Oct 2, 2024
llama_stack/apis/inference/client.py
Outdated
| messages=[message], | ||
| stream=stream, | ||
| ) | ||
| async for log in EventLogger().log(iterator): | ||
| log.print() | ||
|
|
||
|
|
||
| def main(host: str, port: int, stream: bool = True, mm: bool = False, file: str = None): | ||
| def main(host: str, port: int, stream: bool = True, mm: bool = False, file: Optional[str] = None, model: Optional[str] = None): |
There was a problem hiding this comment.
could you run pre-commit? make sure you install it first
cd llama-stack
pip install pre-commit
pre-commit install
Then run git commit -a --amend (once this time) so it will run and run all the formatting lints.
There was a problem hiding this comment.
Oops, yes, it's about time I install that!
There was a problem hiding this comment.
... and now with automation so you don't have to catch this yourself! #176
russellb
force-pushed
the
inference-client-model-choice
branch
from
da51106
to
e91e9cc
Compare
I was running this client for testing purposes and being able to specify which model to use is a convenient addition. This change makes that possible. Signed-off-by: Russell Bryant <rbryant@redhat.com>
A couple of arguments were Optional string arguments, but not marked as such. We were getting some warnings as a result. Signed-off-by: Russell Bryant <rbryant@redhat.com>
russellb
force-pushed
the
inference-client-model-choice
branch
from
e91e9cc
to
242632a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was running this client for testing purposes and being able to
specify which model to use is a convenient addition. This change makes
that possible.
Signed-off-by: Russell Bryant rbryant@redhat.com